Fix for URL opening code

chrome/browser/app_controller_mac.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/app_controller_mac.h"
 
 #include <stddef.h>
 
 #include "base/auto_reset.h"
 #include "base/bind.h"
@@ skipping 1262 matching lines @@
 // Various methods to open URLs that we get in a native fashion. We use
 // StartupBrowserCreator here because on the other platforms, URLs to open come
 // through the ProcessSingleton, and it calls StartupBrowserCreator. It's best
 // to bottleneck the openings through that for uniform handling.
 - (void)openUrls:(const std::vector<GURL>&)urls {
   if (!startupComplete_) {
     startupUrls_.insert(startupUrls_.end(), urls.begin(), urls.end());
     return;
   }
 
-  Browser* browser = chrome::GetLastActiveBrowser();
-  // if no browser window exists then create one with no tabs to be filled in
-  if (!browser) {
-    browser = new Browser(Browser::CreateParams([self lastProfile], true));
-    browser->window()->Show();
+  Profile* profile = [self lastProfile];
+  SessionStartupPref pref = StartupBrowserCreator::GetSessionStartupPref(
+      *base::CommandLine::ForCurrentProcess(), profile);
+
+  if (pref.type == SessionStartupPref::LAST &&
+      SessionRestore::IsRestoring(profile)) {
+    // In case of session restore, remember |urls|, so they will be opened
+    // after session is resored, in the tabs next to it.
+    SessionRestore::AddURLsToOpen(profile, urls);
+  } else {
+    Browser* browser = chrome::GetLastActiveBrowser();
+    // if no browser window exists then create one with no tabs to be filled in

[Avi (use Gerrit), 2017/05/04 23:47:43]

While you're here, turn this into a sentence with a capital letter at the
beginning and a period at the end.

[eugenebng, 2017/05/15 06:17:08]

Done.

+    if (!browser && pref.type != SessionStartupPref::LAST) {

[Avi (use Gerrit), 2017/05/04 23:47:43]

I'm not clear on this line. So if there is no browser open, but we are doing
LAST, then we pass a nullptr into launch.OpenURLsInBrowser? It's only going to
end up creating a browser window itself...

[eugenebng, 2017/05/15 06:17:08]

Fixed this logic, so that it now handles 3 open URL cases:
1) Chromium is already started (with browser window and existing tabs).
2) Chromium app is started, but no windows.
3)Chromium is not started when opening URL.

+      browser = new Browser(Browser::CreateParams([self lastProfile], true));
+      browser->window()->Show();
+    }
+    base::CommandLine dummy(base::CommandLine::NO_PROGRAM);
+    chrome::startup::IsFirstRun first_run =
+        first_run::IsChromeFirstRun() ? chrome::startup::IS_FIRST_RUN
+                                      : chrome::startup::IS_NOT_FIRST_RUN;
+    StartupBrowserCreatorImpl launch(base::FilePath(), dummy, first_run);
+    launch.OpenURLsInBrowser(browser, false, urls);
   }
-
-  base::CommandLine dummy(base::CommandLine::NO_PROGRAM);
-  chrome::startup::IsFirstRun first_run = first_run::IsChromeFirstRun() ?
-      chrome::startup::IS_FIRST_RUN : chrome::startup::IS_NOT_FIRST_RUN;
-  StartupBrowserCreatorImpl launch(base::FilePath(), dummy, first_run);
-  launch.OpenURLsInBrowser(browser, false, urls);
 }
 
 - (void)getUrl:(NSAppleEventDescriptor*)event
      withReply:(NSAppleEventDescriptor*)reply {
   NSString* urlStr = [[event paramDescriptorForKeyword:keyDirectObject]
                       stringValue];
 
   GURL gurl(base::SysNSStringToUTF8(urlStr));
   std::vector<GURL> gurlVector;
   gurlVector.push_back(gurl);
@@ skipping 303 matching lines @@
 
 //---------------------------------------------------------------------------
 
 namespace app_controller_mac {
 
 bool IsOpeningNewWindow() {
   return g_is_opening_new_window;
 }
 
 }  // namespace app_controller_mac