Fix for URL opening code

chrome/browser/app_controller_mac.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/app_controller_mac.h"
 
 #include <stddef.h>
 
 #include "base/auto_reset.h"
 #include "base/bind.h"
@@ skipping 1250 matching lines @@
 
   const PrefService* prefs = g_browser_process->local_state();
   return !profile->IsGuestSession() ||
          prefs->GetBoolean(prefs::kBrowserGuestModeEnabled);
 }
 
 // Various methods to open URLs that we get in a native fashion. We use
 // StartupBrowserCreator here because on the other platforms, URLs to open come
 // through the ProcessSingleton, and it calls StartupBrowserCreator. It's best
 // to bottleneck the openings through that for uniform handling.
 - (void)openUrls:(const std::vector<GURL>&)urls {

[sky, 2017/04/07 21:52:14]

I'm not familiar with the startup sequence on the mac. At what point is this
called? Before or after session restore has run?

[eugenebng, 2017/04/10 11:54:08]

This happens before session restore.
To be more detailed, this happens when applicationDidFinishLaunching, which
happens when session restore starts run loop (but not restored session yet).

   if (!startupComplete_) {
     startupUrls_.insert(startupUrls_.end(), urls.begin(), urls.end());
     return;
   }
 
+  chrome::startup::IsFirstRun first_run = first_run::IsChromeFirstRun() ?
+      chrome::startup::IS_FIRST_RUN : chrome::startup::IS_NOT_FIRST_RUN;
+  StartupBrowserCreatorImpl launch(base::FilePath(),
+                                   *base::CommandLine::ForCurrentProcess(),
+                                   first_run);
   Browser* browser = chrome::GetLastActiveBrowser();
-  // if no browser window exists then create one with no tabs to be filled in
+  bool show_browser = false;
   if (!browser) {
     browser = new Browser(Browser::CreateParams([self lastProfile], true));
-    browser->window()->Show();
+    show_browser = true;
   }
-
-  base::CommandLine dummy(base::CommandLine::NO_PROGRAM);
-  chrome::startup::IsFirstRun first_run = first_run::IsChromeFirstRun() ?
-      chrome::startup::IS_FIRST_RUN : chrome::startup::IS_NOT_FIRST_RUN;
-  StartupBrowserCreatorImpl launch(base::FilePath(), dummy, first_run);
-  launch.OpenURLsInBrowser(browser, false, urls);
+  if (launch.WillRestoreSession(browser, [self lastProfile], false, urls)) {
+    launch.OpenURLsAfterSessionRestore(browser, false, urls);
+  } else {
+    // if no browser window exists then create one with no tabs to be filled in
+    if (show_browser)
+      browser->window()->Show();
+    launch.OpenURLsInBrowser(browser, false, urls);
+  }
 }
 
 - (void)getUrl:(NSAppleEventDescriptor*)event
      withReply:(NSAppleEventDescriptor*)reply {
   NSString* urlStr = [[event paramDescriptorForKeyword:keyDirectObject]
                       stringValue];
 
   GURL gurl(base::SysNSStringToUTF8(urlStr));
   std::vector<GURL> gurlVector;
   gurlVector.push_back(gurl);
@@ skipping 303 matching lines @@
 
 //---------------------------------------------------------------------------
 
 namespace app_controller_mac {
 
 bool IsOpeningNewWindow() {
   return g_is_opening_new_window;
 }
 
 }  // namespace app_controller_mac