Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Unified Diff: content/browser/media/session/media_session_impl_service_routing_unittest.cc

Issue 2798083002: Record user interactions with MediaSession by action type (Closed)
Patch Set: addressed style nits Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/media/session/media_session_impl_service_routing_unittest.cc
diff --git a/content/browser/media/session/media_session_impl_service_routing_unittest.cc b/content/browser/media/session/media_session_impl_service_routing_unittest.cc
index 422897babf8715c9ecb0bb7a24e04bc5781ad793..66853387d6e10ab7b2ff3ad7855ce84a9dc89760 100644
--- a/content/browser/media/session/media_session_impl_service_routing_unittest.cc
+++ b/content/browser/media/session/media_session_impl_service_routing_unittest.cc
@@ -65,7 +65,7 @@ class MockMediaSessionPlayerObserver : public MediaSessionPlayerObserver {
MOCK_METHOD2(OnSetVolumeMultiplier,
void(int player_id, double volume_multiplier));
- RenderFrameHost* GetRenderFrameHost() const override {
+ RenderFrameHost* render_frame_host() const override {
return render_frame_host_;
}
@@ -89,10 +89,6 @@ class MediaSessionImplServiceRoutingTest
MediaSessionImpl::Get(contents())));
main_frame_ = contents()->GetMainFrame();
sub_frame_ = main_frame_->AppendChild("sub_frame");
-
- player_in_main_frame_.reset(
- new MockMediaSessionPlayerObserver(main_frame_));
- player_in_sub_frame_.reset(new MockMediaSessionPlayerObserver(sub_frame_));
}
void TearDown() override {
@@ -154,9 +150,6 @@ class MediaSessionImplServiceRoutingTest
TestRenderFrameHost* main_frame_;
TestRenderFrameHost* sub_frame_;
- std::unique_ptr<MockMediaSessionPlayerObserver> player_in_main_frame_;
- std::unique_ptr<MockMediaSessionPlayerObserver> player_in_sub_frame_;
-
std::unique_ptr<MockMediaSessionObserver> mock_media_session_observer_;
using ServiceMap = std::map<TestRenderFrameHost*,
« no previous file with comments | « content/browser/media/session/media_session_impl.cc ('k') | content/browser/media/session/media_session_impl_uma_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698