[turbofan] Add type to the allocation operator.

src/compiler/simplified-operator.h

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_COMPILER_SIMPLIFIED_OPERATOR_H_
 #define V8_COMPILER_SIMPLIFIED_OPERATOR_H_
 
 #include <iosfwd>
 
 #include "src/base/compiler-specific.h"
@@ skipping 227 matching lines @@
 size_t hash_value(NumberOperationHint);
 
 V8_EXPORT_PRIVATE std::ostream& operator<<(std::ostream&, NumberOperationHint);
 
 NumberOperationHint NumberOperationHintOf(const Operator* op)
     WARN_UNUSED_RESULT;
 
 int FormalParameterCountOf(const Operator* op) WARN_UNUSED_RESULT;
 bool IsRestLengthOf(const Operator* op) WARN_UNUSED_RESULT;
 
+struct AllocationParameters {

[Benedikt Meurer, 2017/04/06 12:08:05]

Nit: AllocateParameters

[Jarin, 2017/04/06 15:11:29]

Done.

+  Type* type;

[Benedikt Meurer, 2017/04/06 12:08:05]

Can we please stick to classes here?

[Jarin, 2017/04/06 15:11:29]

Done.

Out of curiosity, what is the rationale behind using classes for such simple
data structures? (I think even the style guide allows using structs.)

[Benedikt Meurer, 2017/04/06 17:22:28]

I'd like to have some consistency. Switching to structs should be done
consistently. What worries me about structs is the refactoring bugs in C++
because of magical self healing.

+  PretenureFlag pretenure;
+
+  AllocationParameters(Type* type, PretenureFlag pretenure)
+      : type(type), pretenure(pretenure) {}
+};
+
+size_t hash_value(AllocationParameters);
+
+V8_EXPORT_PRIVATE std::ostream& operator<<(std::ostream&, AllocationParameters);
+
+bool operator==(AllocationParameters const&, AllocationParameters const&);
+bool operator!=(AllocationParameters const&, AllocationParameters const&);
+
 PretenureFlag PretenureFlagOf(const Operator* op) WARN_UNUSED_RESULT;
 
+Type* AllocateTypeOf(const Operator* op) WARN_UNUSED_RESULT;
+
 UnicodeEncoding UnicodeEncodingOf(const Operator*) WARN_UNUSED_RESULT;
 
 // Interface for building simplified operators, which represent the
 // medium-level operations of V8, including adding numbers, allocating objects,
 // indexing into objects and arrays, etc.
 // All operators are typed but many are representation independent.
 
 // Number values from JS can be in one of these representations:
 //   - Tagged: word-sized integer that is either
 //     - a signed small integer (31 or 32 bits plus a tag)
@@ skipping 175 matching lines @@
 
   // ensure-writable-fast-elements object, elements
   const Operator* EnsureWritableFastElements();
 
   // maybe-grow-fast-elements object, elements, index, length
   const Operator* MaybeGrowFastElements(GrowFastElementsFlags flags);
 
   // transition-elements-kind object, from-map, to-map
   const Operator* TransitionElementsKind(ElementsTransition transition);
 
-  const Operator* Allocate(PretenureFlag pretenure = NOT_TENURED);
+  const Operator* Allocate(Type* type, PretenureFlag pretenure = NOT_TENURED);
 
   const Operator* LoadField(FieldAccess const&);
   const Operator* StoreField(FieldAccess const&);
 
   // load-buffer buffer, offset, length
   const Operator* LoadBuffer(BufferAccess);
 
   // store-buffer buffer, offset, length, value
   const Operator* StoreBuffer(BufferAccess);
 
@@ skipping 16 matching lines @@
   Zone* const zone_;
 
   DISALLOW_COPY_AND_ASSIGN(SimplifiedOperatorBuilder);
 };
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_COMPILER_SIMPLIFIED_OPERATOR_H_