Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2478)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2797993005: Re-land socket refactor with fixes for Windows. (Closed)

Created:
3 years, 8 months ago by bkonyi
Modified:
3 years, 8 months ago
Reviewers:
zra
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Re-land socket refactor with fixes for Windows. BUG= R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/ddc4f30d75a3c1232b4f89a72c4f40651666a2aa

Patch Set 1 #

Patch Set 2 : Fixed a couple of places still refering to Socket::Initialize() in Windows files #

Patch Set 3 : Rebased + reverted original revert #

Unified diffs Side-by-side diffs Delta from patch set Stats (+843 lines, -3651 lines) Patch
M runtime/bin/eventhandler_win.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/file_system_watcher_linux.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/io_impl_sources.gypi View 1 2 1 chunk +13 lines, -5 lines 0 comments Download
M runtime/bin/io_natives.cc View 1 2 1 chunk +10 lines, -10 lines 0 comments Download
M runtime/bin/platform_win.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/process_win.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/socket.h View 1 2 4 chunks +4 lines, -289 lines 0 comments Download
M runtime/bin/socket.cc View 1 2 26 chunks +28 lines, -59 lines 0 comments Download
D runtime/bin/socket_android.h View 1 2 1 chunk +0 lines, -16 lines 0 comments Download
M runtime/bin/socket_android.cc View 1 2 7 chunks +3 lines, -370 lines 0 comments Download
A + runtime/bin/socket_base.h View 1 2 5 chunks +13 lines, -202 lines 0 comments Download
A runtime/bin/socket_base.cc View 1 2 1 chunk +62 lines, -0 lines 0 comments Download
A + runtime/bin/socket_base_android.h View 1 2 1 chunk +5 lines, -5 lines 0 comments Download
A + runtime/bin/socket_base_android.cc View 1 2 25 chunks +61 lines, -249 lines 0 comments Download
A + runtime/bin/socket_base_fuchsia.h View 1 2 1 chunk +5 lines, -5 lines 0 comments Download
A runtime/bin/socket_base_fuchsia.cc View 1 2 1 chunk +376 lines, -0 lines 0 comments Download
A + runtime/bin/socket_base_linux.h View 1 2 1 chunk +5 lines, -5 lines 0 comments Download
A + runtime/bin/socket_base_linux.cc View 1 2 26 chunks +61 lines, -225 lines 0 comments Download
A + runtime/bin/socket_base_macos.h View 1 2 1 chunk +5 lines, -5 lines 0 comments Download
A + runtime/bin/socket_base_macos.cc View 1 2 25 chunks +61 lines, -239 lines 0 comments Download
A runtime/bin/socket_base_unsupported.cc View 1 2 1 chunk +38 lines, -0 lines 0 comments Download
A + runtime/bin/socket_base_win.h View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
A + runtime/bin/socket_base_win.cc View 1 2 22 chunks +66 lines, -304 lines 0 comments Download
D runtime/bin/socket_fuchsia.h View 1 2 1 chunk +0 lines, -16 lines 0 comments Download
M runtime/bin/socket_fuchsia.cc View 1 2 7 chunks +5 lines, -312 lines 0 comments Download
D runtime/bin/socket_linux.h View 1 2 1 chunk +0 lines, -16 lines 0 comments Download
M runtime/bin/socket_linux.cc View 1 2 7 chunks +5 lines, -412 lines 0 comments Download
D runtime/bin/socket_macos.h View 1 2 1 chunk +0 lines, -16 lines 0 comments Download
M runtime/bin/socket_macos.cc View 1 2 7 chunks +3 lines, -426 lines 0 comments Download
M runtime/bin/socket_patch.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/socket_unsupported.cc View 1 2 2 chunks +0 lines, -17 lines 0 comments Download
D runtime/bin/socket_win.h View 1 2 1 chunk +0 lines, -17 lines 0 comments Download
M runtime/bin/socket_win.cc View 1 2 8 chunks +4 lines, -421 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
bkonyi
Here's the updated change with the fixes for Windows. Will rebase to get your most ...
3 years, 8 months ago (2017-04-05 18:03:52 UTC) #2
zra
Does this go on top of the previous CL that got reverted?
3 years, 8 months ago (2017-04-05 18:10:16 UTC) #3
bkonyi
Rebased + added back the refactored files. PTAL.
3 years, 8 months ago (2017-04-05 18:35:37 UTC) #4
zra
lgtm
3 years, 8 months ago (2017-04-05 19:35:06 UTC) #5
bkonyi
3 years, 8 months ago (2017-04-05 19:45:46 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
ddc4f30d75a3c1232b4f89a72c4f40651666a2aa (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698