Set plugin focus via element dispatch

third_party/WebKit/Source/core/dom/Document.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  *           (C) 2006 Alexey Proskuryakov (ap@webkit.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All
  * rights reserved.
  * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved.
  * (http://www.torchmobile.com/)
  * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved.
@@ skipping 348 matching lines @@
     return false;
 
   // rule (d) above
   CharDecompositionType decompType = decompositionType(c);
   if (decompType == DecompositionFont || decompType == DecompositionCompat)
     return false;
 
   return true;
 }
 
-static FrameViewBase* frameViewBaseForElement(const Element& focusedElement) {
-  LayoutObject* layoutObject = focusedElement.layoutObject();
-  if (!layoutObject || !layoutObject->isLayoutPart())
-    return 0;
-  return toLayoutPart(layoutObject)->frameViewBase();
-}
-
 static bool acceptsEditingFocus(const Element& element) {
   DCHECK(hasEditableStyle(element));
 
   return element.document().frame() && rootEditableElement(element);
 }
 
 uint64_t Document::s_globalTreeVersion = 0;
 
 static bool s_threadedParsingEnabledForTesting = true;
 
@@ skipping 3637 matching lines @@
   // Remove focus from the existing focus node (if any)
   if (oldFocusedElement) {
     oldFocusedElement->setFocused(false);
 
     // Dispatch the blur event and let the node do any other blur related
     // activities (important for text fields)
     // If page lost focus, blur event will have already been dispatched
     if (page() && (page()->focusController().isFocused())) {
       oldFocusedElement->dispatchBlurEvent(newFocusedElement, params.type,
                                            params.sourceCapabilities);
-
       if (m_focusedElement) {
         // handler shifted focus
         focusChangeBlocked = true;
         newFocusedElement = nullptr;
       }
 
       // 'focusout' is a DOM level 3 name for the bubbling blur event.
       oldFocusedElement->dispatchFocusOutEvent(EventTypeNames::focusout,
                                                newFocusedElement,
                                                params.sourceCapabilities);
       // 'DOMFocusOut' is a DOM level 2 name for compatibility.
       // FIXME: We should remove firing DOMFocusOutEvent event when we are sure
       // no content depends on it, probably when <rdar://problem/8503958> is
       // resolved.
       oldFocusedElement->dispatchFocusOutEvent(EventTypeNames::DOMFocusOut,
                                                newFocusedElement,
                                                params.sourceCapabilities);
 
       if (m_focusedElement) {
         // handler shifted focus
         focusChangeBlocked = true;
         newFocusedElement = nullptr;
       }
     }
-
-    if (view()) {
-      FrameViewBase* oldFrameViewBase =
-          frameViewBaseForElement(*oldFocusedElement);
-      if (oldFrameViewBase)
-        oldFrameViewBase->setFocused(false, params.type);
-      else
-        view()->setFocused(false, params.type);
-    }
   }
 
   if (newFocusedElement)
     updateStyleAndLayoutTreeForNode(newFocusedElement);
   if (newFocusedElement && newFocusedElement->isFocusable()) {
     if (isRootEditableElement(*newFocusedElement) &&
         !acceptsEditingFocus(*newFocusedElement)) {
       // delegate blocks focus change
       focusChangeBlocked = true;
       goto SetFocusedElementDone;
@@ skipping 44 matching lines @@
 
       if (m_focusedElement != newFocusedElement) {
         // handler shifted focus
         focusChangeBlocked = true;
         goto SetFocusedElementDone;
       }
     }
 
     if (isRootEditableElement(*m_focusedElement))
       frame()->spellChecker().didBeginEditing(m_focusedElement.get());
-
-    // eww, I suck. set the qt focus correctly
-    // ### find a better place in the code for this
-    if (view()) {
-      FrameViewBase* focusFrameViewBase =
-          frameViewBaseForElement(*m_focusedElement);
-      if (focusFrameViewBase) {
-        // Make sure a FrameViewBase has the right size before giving it focus.
-        // Otherwise, we are testing edge cases of the FrameViewBase code.
-        // Specifically, in WebCore this does not work well for text fields.
-        updateStyleAndLayout();

[haraken, 2017/04/05 11:59:00]

Is it okay to remove updateStyleAndLayout()?

[joelhockey, 2017/04/05 23:59:11]

I don't really know, but I can say that all the tests still pass.  I can't think
how moving focus in or out of the plugin requires a style update.  This code is
from 2006 and I suspect it isn't needed, but no-one has been game to touch it?

-        // Re-get the FrameViewBase in case updating the layout changed things.
-        focusFrameViewBase = frameViewBaseForElement(*m_focusedElement);
-      }
-      if (focusFrameViewBase)
-        focusFrameViewBase->setFocused(true, params.type);
-      else
-        view()->setFocused(true, params.type);

[dcheng, 2017/04/05 07:48:08]

I think we can delete setFocused() off FrameViewBase as well, right?

[joelhockey, 2017/04/05 23:59:11]

Yes, done

-    }
   }
 
   if (!focusChangeBlocked && m_focusedElement) {
     // Create the AXObject cache in a focus change because Chromium relies on
     // it.
     if (AXObjectCache* cache = axObjectCache())
       cache->handleFocusedUIElementChanged(oldFocusedElement,
                                            newFocusedElement);
   }
 
@@ skipping 2468 matching lines @@
 }
 
 void showLiveDocumentInstances() {
   WeakDocumentSet& set = liveDocumentSet();
   fprintf(stderr, "There are %u documents currently alive:\n", set.size());
   for (blink::Document* document : set)
     fprintf(stderr, "- Document %p URL: %s\n", document,
             document->url().getString().utf8().data());
 }
 #endif