Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1677)

Unified Diff: chrome/browser/ui/views/browser_dialogs_views_mac.cc

Issue 2797923003: Rename PageInfoPopupView to PageInfoBubbleView. (Closed)
Patch Set: Rename more stuff. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/browser_dialogs_views_mac.cc
diff --git a/chrome/browser/ui/views/browser_dialogs_views_mac.cc b/chrome/browser/ui/views/browser_dialogs_views_mac.cc
index ea4ab31d0650795289f96b5ca8752e0475b5c730..60225d92dca0905d39117265ef763a8be80a04dd 100644
--- a/chrome/browser/ui/views/browser_dialogs_views_mac.cc
+++ b/chrome/browser/ui/views/browser_dialogs_views_mac.cc
@@ -9,7 +9,7 @@
#include "chrome/browser/ui/browser_dialogs.h"
#include "chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h"
#include "chrome/browser/ui/views/content_setting_bubble_contents.h"
-#include "chrome/browser/ui/views/page_info/page_info_popup_view.h"
+#include "chrome/browser/ui/views/page_info/page_info_bubble_view.h"
#include "chrome/browser/ui/views/task_manager_view.h"
#include "chrome/browser/ui/views/update_recommended_message_box.h"
@@ -34,13 +34,14 @@ void ShowPageInfoBubbleViewsAtPoint(
// earlier because the popup is shown on mouse release (but dismissed on
msw 2017/04/05 19:27:20 nit: s/popup/bubble/
// mouse pressed). A Cocoa browser does both on mouse pressed, so a check
// when showing is sufficient.
- if (PageInfoPopupView::GetShownPopupType() != PageInfoPopupView::POPUP_NONE) {
+ if (PageInfoBubbleView::GetShownBubbleType() !=
+ PageInfoBubbleView::BUBBLE_NONE) {
return;
}
- PageInfoPopupView::ShowPopup(nullptr, gfx::Rect(anchor_point, gfx::Size()),
- profile, web_contents, virtual_url,
- security_info);
+ PageInfoBubbleView::ShowBubble(nullptr, gfx::Rect(anchor_point, gfx::Size()),
+ profile, web_contents, virtual_url,
+ security_info);
}
void ShowBookmarkBubbleViewsAtPoint(const gfx::Point& anchor_point,

Powered by Google App Engine
This is Rietveld 408576698