Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8453)

Unified Diff: chrome/browser/ui/views/page_info/page_info_popup_view.h

Issue 2797923003: Rename PageInfoPopupView to PageInfoBubbleView. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/page_info/page_info_popup_view.h
diff --git a/chrome/browser/ui/views/page_info/page_info_popup_view.h b/chrome/browser/ui/views/page_info/page_info_popup_view.h
index c8843627be5827c6c3d7f830ad43e9ad035768e4..b2afa58b937a1115f1c70e11c1e0f93d1e7ccd0f 100644
--- a/chrome/browser/ui/views/page_info/page_info_popup_view.h
+++ b/chrome/browser/ui/views/page_info/page_info_popup_view.h
@@ -38,7 +38,7 @@ struct SecurityInfo;
} // namespace security_state
namespace test {
-class PageInfoPopupViewTestApi;
+class PageInfoBubbleViewTestApi;
}
namespace views {
@@ -54,16 +54,16 @@ enum : int {
};
// The views implementation of the page info UI.
-class PageInfoPopupView : public content::WebContentsObserver,
- public PermissionSelectorRowObserver,
- public ChosenObjectRowObserver,
- public views::BubbleDialogDelegateView,
- public views::ButtonListener,
- public views::LinkListener,
- public views::StyledLabelListener,
- public PageInfoUI {
+class PageInfoBubbleView : public content::WebContentsObserver,
+ public PermissionSelectorRowObserver,
+ public ChosenObjectRowObserver,
+ public views::BubbleDialogDelegateView,
+ public views::ButtonListener,
+ public views::LinkListener,
+ public views::StyledLabelListener,
+ public PageInfoUI {
public:
- ~PageInfoPopupView() override;
+ ~PageInfoBubbleView() override;
// Type of the popup being displayed.
enum PopupType {
@@ -86,14 +86,14 @@ class PageInfoPopupView : public content::WebContentsObserver,
static PopupType GetShownPopupType();
private:
- friend class test::PageInfoPopupViewTestApi;
+ friend class test::PageInfoBubbleViewTestApi;
- PageInfoPopupView(views::View* anchor_view,
- gfx::NativeView parent_window,
- Profile* profile,
- content::WebContents* web_contents,
- const GURL& url,
- const security_state::SecurityInfo& security_info);
+ PageInfoBubbleView(views::View* anchor_view,
+ gfx::NativeView parent_window,
+ Profile* profile,
+ content::WebContents* web_contents,
+ const GURL& url,
+ const security_state::SecurityInfo& security_info);
// WebContentsObserver implementation.
void RenderFrameDeleted(content::RenderFrameHost* render_frame_host) override;
@@ -177,9 +177,9 @@ class PageInfoPopupView : public content::WebContentsObserver,
// |Permission| changes.
std::vector<std::unique_ptr<PermissionSelectorRow>> selector_rows_;
- base::WeakPtrFactory<PageInfoPopupView> weak_factory_;
+ base::WeakPtrFactory<PageInfoBubbleView> weak_factory_;
- DISALLOW_COPY_AND_ASSIGN(PageInfoPopupView);
+ DISALLOW_COPY_AND_ASSIGN(PageInfoBubbleView);
};
#endif // CHROME_BROWSER_UI_VIEWS_PAGE_INFO_PAGE_INFO_POPUP_VIEW_H_

Powered by Google App Engine
This is Rietveld 408576698