android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java - Issue 2797893002: Prevent Android webview tests from being broken by data URL deprecation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java

Issue 2797893002: Prevent Android webview tests from being broken by data URL deprecation (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldOverrideUrlLoadingTest.java ('K') | « android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldOverrideUrlLoadingTest.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java

diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java

index b10e50e2a59e577681d046b14e90d6a4b14ba26d..f304368aa5d09587e72410cfd0c793d67aa75af4 100644

--- a/android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java

+++ b/android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java

@@ -1182,10 +1182,14 @@ public class AwSettingsTest extends AwTestBase {

return "<html><head>"

+ "<script>"

+ " function tryOpenWindow() {"

- + " var newWindow = window.open("

- + " 'data:text/html;charset=utf-8,"

- + " <html><head><title>" + POPUP_ENABLED + "</title></head></html>');"

- + " if (!newWindow) document.title = '" + POPUP_BLOCKED + "';"

+ + " var newWindow = window.open('about:blank');"

+ + " if (newWindow) {"

+ + " newWindow.document.write("

+ + " '<html><head><title>" + POPUP_ENABLED

+ + "</title></head></html>');"

+ + " } else {"

+ + " document.title = '" + POPUP_BLOCKED + "';"

+ + " }"

+ " }"

+ "</script></head>"

+ "<body onload='tryOpenWindow()'></body></html>";