Preserve async markers when parsing js_ast

Preserve async markers when parsing js_ast

Fixes #29252

R=jmesserly@google.com

Committed: https://github.com/dart-lang/sdk/commit/aa3fba7d8dfebb947a09aa4e1228e81a3b0cd058

[vsm, 2017-04-04 23:27:38]

Description was changed from

==========
Preserve async markers when parsing js_ast

Fixes #29252
==========

to

==========
Preserve async markers when parsing js_ast

Fixes #29252
==========

[vsm, 2017-04-04 23:27:38]

vsm@google.com changed reviewers:
+ jmesserly@google.com

[Jennifer Messerly, 2017-04-04 23:34:25]

LGTM!!!

https://codereview.chromium.org/2797873002/diff/1/tests/language_strong/async...
File tests/language_strong/async_cascade_test.dart (right):

https://codereview.chromium.org/2797873002/diff/1/tests/language_strong/async...
tests/language_strong/async_cascade_test.dart:11: _x ??= new Future(() async {
is it worth adding a comment about what's going on here?

// this is the outer metalet which incorrectly copies function* to function

https://codereview.chromium.org/2797873002/diff/1/tests/language_strong/async...
tests/language_strong/async_cascade_test.dart:13: list = list.toList()..add(z);
// this triggers a nested MetaLet which breaks the outer one

[vsm, 2017-04-05 19:13:32]

Description was changed from

==========
Preserve async markers when parsing js_ast

Fixes #29252
==========

to

==========
Preserve async markers when parsing js_ast

Fixes #29252

R=jmesserly@google.com

Committed:
https://github.com/dart-lang/sdk/commit/aa3fba7d8dfebb947a09aa4e1228e81a3b0cd058
==========

[vsm, 2017-04-05 19:13:33]

Committed patchset #2 (id:20001) manually as
aa3fba7d8dfebb947a09aa4e1228e81a3b0cd058 (presubmit successful).

[vsm, 2017-04-05 19:14:31]

https://codereview.chromium.org/2797873002/diff/1/tests/language_strong/async...
File tests/language_strong/async_cascade_test.dart (right):

https://codereview.chromium.org/2797873002/diff/1/tests/language_strong/async...
tests/language_strong/async_cascade_test.dart:11: _x ??= new Future(() async {
On 2017/04/04 23:34:24, Jennifer Messerly wrote:
> is it worth adding a comment about what's going on here?
> 
> // this is the outer metalet which incorrectly copies function* to function

Thanks - added comment pointing to #issue number for explanation.

https://codereview.chromium.org/2797873002/diff/1/tests/language_strong/async...
tests/language_strong/async_cascade_test.dart:13: list = list.toList()..add(z);
On 2017/04/04 23:34:24, Jennifer Messerly wrote:
> // this triggers a nested MetaLet which breaks the outer one

Ditto