Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(530)

Issue 279783002: Delete unnecessary construction of WebSocketFrame in NewWebSocketChannelImpl (Closed)

Created:
6 years, 7 months ago by tyoshino (SeeGerritForStatus)
Modified:
6 years, 7 months ago
Reviewers:
yhirano
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Delete unnecessary construction of WebSocketFrame in NewWebSocketChannelImpl After changes by inspector team that removed dependency from inspector to WebSocket, the construction of WebSocketFrame there is meaningless. Remove them. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173750

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M Source/modules/websockets/NewWebSocketChannelImpl.cpp View 3 chunks +3 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tyoshino (SeeGerritForStatus)
6 years, 7 months ago (2014-05-09 09:37:58 UTC) #1
yhirano
lgtm
6 years, 7 months ago (2014-05-09 10:40:53 UTC) #2
tyoshino (SeeGerritForStatus)
The CQ bit was checked by tyoshino@chromium.org
6 years, 7 months ago (2014-05-09 11:45:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tyoshino@chromium.org/279783002/1
6 years, 7 months ago (2014-05-09 11:46:51 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-09 13:08:46 UTC) #5
Message was sent while issue was closed.
Change committed as 173750

Powered by Google App Engine
This is Rietveld 408576698