Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: third_party/WebKit/Source/web/tests/WebFrameTest.cpp

Issue 2797813002: Replicate feature policy container policies. (Closed)
Patch Set: Addressing review comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/tests/WebFrameTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
index 2a21287098f82229fa91eeb2cedced172e49ee35..7fc8fcc865962610b44ef4cd71fa4365e2ee3c97 100644
--- a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
+++ b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
@@ -7302,6 +7302,7 @@ class TestCachePolicyWebFrameClient
const WebString&,
const WebString&,
WebSandboxFlags,
+ const WebParsedFeaturePolicy&,
const WebFrameOwnerProperties& frame_owner_properties) override {
DCHECK(child_client_);
child_frame_creation_count_++;
@@ -7711,6 +7712,7 @@ class FailCreateChildFrame : public FrameTestHelpers::TestWebFrameClient {
const WebString& name,
const WebString& fallback_name,
WebSandboxFlags sandbox_flags,
+ const WebParsedFeaturePolicy& container_policy,
const WebFrameOwnerProperties& frame_owner_properties) override {
++call_count_;
return nullptr;
@@ -11745,12 +11747,14 @@ TEST_F(WebFrameTest, NoLoadingCompletionCallbacksInDetach) {
class MainFrameClient : public FrameTestHelpers::TestWebFrameClient {
public:
- WebLocalFrame* CreateChildFrame(WebLocalFrame* parent,
- WebTreeScopeType scope,
- const WebString& name,
- const WebString& fallback_name,
- WebSandboxFlags sandbox_flags,
- const WebFrameOwnerProperties&) override {
+ WebLocalFrame* CreateChildFrame(
+ WebLocalFrame* parent,
+ WebTreeScopeType scope,
+ const WebString& name,
+ const WebString& fallback_name,
+ WebSandboxFlags sandbox_flags,
+ const WebParsedFeaturePolicy& container_policy,
+ const WebFrameOwnerProperties&) override {
WebLocalFrame* frame =
WebLocalFrame::Create(scope, &child_client_, nullptr, nullptr);
parent->AppendChild(frame);
@@ -11952,6 +11956,7 @@ class TestFallbackWebFrameClient : public FrameTestHelpers::TestWebFrameClient {
const WebString&,
const WebString&,
WebSandboxFlags,
+ const WebParsedFeaturePolicy& container_policy,
const WebFrameOwnerProperties& frameOwnerProperties) override {
DCHECK(child_client_);
WebLocalFrame* frame =
« no previous file with comments | « third_party/WebKit/Source/web/tests/FrameTestHelpers.cpp ('k') | third_party/WebKit/Source/web/tests/WebViewTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698