Replicate feature policy container policies.

content/browser/frame_host/frame_tree_node.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/frame_host/frame_tree_node.h"
 
 #include <queue>
 #include <utility>
 
 #include "base/lazy_instance.h"
@@ skipping 303 matching lines @@
 
 void FrameTreeNode::SetPendingSandboxFlags(
     blink::WebSandboxFlags sandbox_flags) {
   pending_sandbox_flags_ = sandbox_flags;
 
   // Subframes should always inherit their parent's sandbox flags.
   if (parent())
     pending_sandbox_flags_ |= parent()->effective_sandbox_flags();
 }
 
+void FrameTreeNode::SetPendingContainerPolicy(
+    const ParsedFeaturePolicyHeader& container_policy) {
+  pending_container_policy_ = container_policy;
+}
+
 bool FrameTreeNode::IsDescendantOf(FrameTreeNode* other) const {
   if (!other || !other->child_count())
     return false;
 
   for (FrameTreeNode* node = parent(); node; node = node->parent()) {
     if (node == other)
       return true;
   }
 
   return false;
@@ skipping 23 matching lines @@
         render_manager_.speculative_frame_host();
     if (speculative_frame_host && speculative_frame_host->is_loading())
       return true;
   } else {
     if (pending_frame_host && pending_frame_host->is_loading())
       return true;
   }
   return current_frame_host->is_loading();
 }
 
-bool FrameTreeNode::CommitPendingSandboxFlags() {
+bool FrameTreeNode::CommitPendingFramePolicy() {
   bool did_change_flags =

[lunalu1, 2017/04/05 22:30:03]

nit: s/did_change_flags/did_change_frame_policy/

[iclelland, 2017/04/09 03:25:54]

Separated into two appropriately-named flags instead, in light of the comment
below.

-      pending_sandbox_flags_ != replication_state_.sandbox_flags;
+      pending_sandbox_flags_ != replication_state_.sandbox_flags ||
+      pending_container_policy_ != replication_state_.container_policy;

[lunalu1, 2017/04/05 22:30:03]

container policy is a white-list (WebVector<WebParsedFeaturePolicy>). I am
wondering if we have the same policy, but the items are out of order, or the
WebParsedFeaturePolicy is the same order, but inside the origins are in
different order. Do we need to update it?

[iclelland, 2017/04/11 17:41:43]

We don't need to, in that case, but in practice that's not going to happen until
we have something like the full JSON-allow-syntax on iframe elements. And I
believe that even if it does, there is no harm in updating with a
semantically-identical container policy anyway.

   replication_state_.sandbox_flags = pending_sandbox_flags_;

[lunalu1, 2017/04/05 22:30:03]

We don't need to reassign the value, unless the value has been changed right? So
I am wondering if it would be more efficient to only reassign when the value is
changed. But that might be a few more lines of code (so probably not worth it).

[iclelland, 2017/04/09 03:25:54]

Done.

+  replication_state_.container_policy = pending_container_policy_;
   return did_change_flags;
 }
 
 void FrameTreeNode::CreatedNavigationRequest(
     std::unique_ptr<NavigationRequest> navigation_request) {
   CHECK(IsBrowserSideNavigationEnabled());
 
   // This is never called when navigating to a Javascript URL. For the loading
   // state, this matches what Blink is doing: Blink doesn't send throbber
   // notifications for Javascript URLS.
@@ skipping 192 matching lines @@
       }
       return parent_->child_at(i + relative_offset);
     }
   }
 
   NOTREACHED() << "FrameTreeNode not found in its parent's children.";
   return nullptr;
 }
 
 }  // namespace content