Replicate feature policy container policies.

third_party/WebKit/Source/core/frame/FrameOwner.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef FrameOwner_h
 #define FrameOwner_h
 
 #include "core/CoreExport.h"
 #include "core/dom/SandboxFlags.h"
 #include "platform/heap/Handle.h"
@@ skipping 33 matching lines @@
   // https://html.spec.whatwg.org/multipage/browsers.html#browsing-context-container
   virtual AtomicString BrowsingContextContainerName() const = 0;
   virtual ScrollbarMode ScrollingMode() const = 0;
   virtual int MarginWidth() const = 0;
   virtual int MarginHeight() const = 0;
   virtual bool AllowFullscreen() const = 0;
   virtual bool AllowPaymentRequest() const = 0;
   virtual bool IsDisplayNone() const = 0;
   virtual AtomicString Csp() const = 0;
   virtual const WebVector<WebFeaturePolicyFeature>& AllowedFeatures() const = 0;
+  virtual const WebParsedFeaturePolicy& ContainerPolicy() const = 0;
 };
 
 // TODO(dcheng): This class is an internal implementation detail of provisional
 // frames. Move this into WebLocalFrameImpl.cpp and remove existing dependencies
 // on it.
 class CORE_EXPORT DummyFrameOwner
     : public GarbageCollectedFinalized<DummyFrameOwner>,
       public FrameOwner {
   USING_GARBAGE_COLLECTED_MIXIN(DummyFrameOwner);
 
@@ skipping 17 matching lines @@
   int MarginWidth() const override { return -1; }
   int MarginHeight() const override { return -1; }
   bool AllowFullscreen() const override { return false; }
   bool AllowPaymentRequest() const override { return false; }
   bool IsDisplayNone() const override { return false; }
   AtomicString Csp() const override { return g_null_atom; }
   const WebVector<WebFeaturePolicyFeature>& AllowedFeatures() const override {
     DEFINE_STATIC_LOCAL(WebVector<WebFeaturePolicyFeature>, features, ());
     return features;
   }
+  const WebParsedFeaturePolicy& ContainerPolicy() const override {
+    DEFINE_STATIC_LOCAL(WebParsedFeaturePolicy, container_policy, ());
+    return container_policy;

[dcheng, 2017/04/18 16:26:37]

Nit: it's unclear to me why we need a static local for this; we expect this to
be called basically only for tests. I would just return WebParsedFeaturePolicy()
and not bother with the static local.

(Ditto for 89-90, but it's OK to leave that for now, since that's not changed by
this CL)

[iclelland, 2017/04/18 19:19:44]

It needs to return a reference (the other non-test implementations return a
reference to the real policy), and so can't just use a temporary. I could add an
actual member var, with basically the same effect, but I thought that following
the existing pattern made sense.

+  }
 
  private:
   // Intentionally private to prevent redundant checks when the type is
   // already DummyFrameOwner.
   bool IsLocal() const override { return false; }
   bool IsRemote() const override { return false; }
 };
 
 }  // namespace blink
 
 #endif  // FrameOwner_h