Chromium Code Reviews| Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartDataProvider.js |
| diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartDataProvider.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartDataProvider.js |
| index 65e833d9ac1510079c0c73e6984c7d904010429d..70ce8976319573a5d0bfe4df31c1fd7740b6fea1 100644 |
| --- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartDataProvider.js |
| +++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartDataProvider.js |
| @@ -875,23 +875,26 @@ Timeline.TimelineFlameChartDataProvider = class { |
| td.flowStartLevels = []; |
| td.flowEndTimes = []; |
| td.flowEndLevels = []; |
| - // Find the closest ancestor with an initiator. |
| - var initiator; |
| - for (; event; event = this._eventParent(event)) { |
| - if (!this._isVisible(event)) |
| - continue; |
| - initiator = TimelineModel.TimelineData.forEvent(event).initiator(); |
| - if (initiator) |
| - break; |
| + while (event) { |
| + // Find the closest ancestor with an initiator. |
| + var initiator; |
| + for (; event; event = this._eventParent(event)) { |
| + if (!this._isVisible(event)) |
|
caseq
2017/04/04 18:07:28
do you still need this check?
|
| + continue; |
| + initiator = TimelineModel.TimelineData.forEvent(event).initiator(); |
| + if (initiator) |
| + break; |
| + } |
| + if (!initiator || !this._isVisible(initiator)) |
| + return true; |
|
caseq
2017/04/04 18:07:28
nit: let's rather break from here.
|
| + var eventIndex = event[Timeline.TimelineFlameChartDataProvider._indexSymbol]; |
| + var initiatorIndex = initiator[Timeline.TimelineFlameChartDataProvider._indexSymbol]; |
| + td.flowStartTimes.push(initiator.endTime || initiator.startTime); |
| + td.flowStartLevels.push(td.entryLevels[initiatorIndex]); |
| + td.flowEndTimes.push(event.startTime); |
| + td.flowEndLevels.push(td.entryLevels[eventIndex]); |
| + event = initiator; |
| } |
| - if (!initiator || !this._isVisible(initiator)) |
| - return true; |
| - var eventIndex = event[Timeline.TimelineFlameChartDataProvider._indexSymbol]; |
| - var initiatorIndex = initiator[Timeline.TimelineFlameChartDataProvider._indexSymbol]; |
| - td.flowStartTimes.push(initiator.endTime || initiator.startTime); |
| - td.flowStartLevels.push(td.entryLevels[initiatorIndex]); |
| - td.flowEndTimes.push(event.startTime); |
| - td.flowEndLevels.push(td.entryLevels[eventIndex]); |
| return true; |
| } |