Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js

Issue 2797763003: DevTools: Show the full chain of initiators on the flame chart. (Closed)
Patch Set: Addressing comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartDataProvider.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * Copyright (C) 2012 Intel Inc. All rights reserved. 3 * Copyright (C) 2012 Intel Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 904 matching lines...) Expand 10 before | Expand all | Expand 10 after
915 contentHelper.appendElementRow( 915 contentHelper.appendElementRow(
916 relatedNodeLabel || Common.UIString('Related Node'), 916 relatedNodeLabel || Common.UIString('Related Node'),
917 Components.DOMPresentationUtils.linkifyNodeReference(relatedNode)); 917 Components.DOMPresentationUtils.linkifyNodeReference(relatedNode));
918 } 918 }
919 919
920 if (event[Timeline.TimelineUIUtils._previewElementSymbol]) { 920 if (event[Timeline.TimelineUIUtils._previewElementSymbol]) {
921 contentHelper.addSection(Common.UIString('Preview')); 921 contentHelper.addSection(Common.UIString('Preview'));
922 contentHelper.appendElementRow('', event[Timeline.TimelineUIUtils._preview ElementSymbol]); 922 contentHelper.appendElementRow('', event[Timeline.TimelineUIUtils._preview ElementSymbol]);
923 } 923 }
924 924
925 if (timelineData.stackTraceForSelfOrInitiator() || TimelineModel.Invalidatio nTracker.invalidationEventsFor(event)) 925 if (initiator || timelineData.stackTraceForSelfOrInitiator() ||
926 TimelineModel.InvalidationTracker.invalidationEventsFor(event))
926 Timeline.TimelineUIUtils._generateCauses(event, model.targetByEvent(event) , relatedNodesMap, contentHelper); 927 Timeline.TimelineUIUtils._generateCauses(event, model.targetByEvent(event) , relatedNodesMap, contentHelper);
927 928
928 var stats = {}; 929 var stats = {};
929 var showPieChart = detailed && Timeline.TimelineUIUtils._aggregatedStatsForT raceEvent(stats, model, event); 930 var showPieChart = detailed && Timeline.TimelineUIUtils._aggregatedStatsForT raceEvent(stats, model, event);
930 if (showPieChart) { 931 if (showPieChart) {
931 contentHelper.addSection(Common.UIString('Aggregated Time')); 932 contentHelper.addSection(Common.UIString('Aggregated Time'));
932 var pieChart = Timeline.TimelineUIUtils.generatePieChart( 933 var pieChart = Timeline.TimelineUIUtils.generatePieChart(
933 stats, Timeline.TimelineUIUtils.eventStyle(event).category, event.self Time); 934 stats, Timeline.TimelineUIUtils.eventStyle(event).category, event.self Time);
934 contentHelper.appendElementRow('', pieChart); 935 contentHelper.appendElementRow('', pieChart);
935 } 936 }
(...skipping 1350 matching lines...) Expand 10 before | Expand all | Expand 10 after
2286 * @param {string=} warningType 2287 * @param {string=} warningType
2287 */ 2288 */
2288 appendWarningRow(event, warningType) { 2289 appendWarningRow(event, warningType) {
2289 var warning = Timeline.TimelineUIUtils.eventWarning(event, warningType); 2290 var warning = Timeline.TimelineUIUtils.eventWarning(event, warningType);
2290 if (warning) 2291 if (warning)
2291 this.appendElementRow(Common.UIString('Warning'), warning, true); 2292 this.appendElementRow(Common.UIString('Warning'), warning, true);
2292 } 2293 }
2293 }; 2294 };
2294 2295
2295 Timeline.TimelineUIUtils._categoryBreakdownCacheSymbol = Symbol('categoryBreakdo wnCache'); 2296 Timeline.TimelineUIUtils._categoryBreakdownCacheSymbol = Symbol('categoryBreakdo wnCache');
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartDataProvider.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698