Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1013)

Unified Diff: chrome/browser/chromeos/system/tray_accessibility_browsertest.cc

Issue 2797743002: ash: Merge LoginStatus update code path (Closed)
Patch Set: for #2 comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/system/tray_accessibility_browsertest.cc
diff --git a/chrome/browser/chromeos/system/tray_accessibility_browsertest.cc b/chrome/browser/chromeos/system/tray_accessibility_browsertest.cc
index 2350790ddfcd6d018f377ecb4bfd1287e9330b59..561a403594d483477ebc72e0ea442caaa80bc82c 100644
--- a/chrome/browser/chromeos/system/tray_accessibility_browsertest.cc
+++ b/chrome/browser/chromeos/system/tray_accessibility_browsertest.cc
@@ -22,6 +22,7 @@
#include "chrome/browser/extensions/api/braille_display_private/mock_braille_controller.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/profiles/profile_manager.h"
+#include "chrome/browser/ui/ash/session_controller_client.h"
#include "chrome/common/chrome_switches.h"
#include "chrome/common/pref_names.h"
#include "chrome/test/base/in_process_browser_test.h"
@@ -342,6 +343,8 @@ IN_PROC_BROWSER_TEST_P(TrayAccessibilityTest, LoginStatus) {
session_manager::SessionManager::Get()->CreateSession(
AccountId::FromUserEmail("owner@invalid.domain"), "owner@invalid.domain");
session_manager::SessionManager::Get()->SessionStarted();
+ // Flush to ensure the session state reaches ash and updates login status.
+ SessionControllerClient::FlushForTesting();
EXPECT_EQ(ash::LoginStatus::USER, GetLoginStatus());
}
@@ -476,6 +479,8 @@ IN_PROC_BROWSER_TEST_P(TrayAccessibilityTest, ShowMenu) {
session_manager::SessionManager::Get()->CreateSession(
AccountId::FromUserEmail("owner@invalid.domain"), "owner@invalid.domain");
session_manager::SessionManager::Get()->SessionStarted();
+ // Flush to ensure the session state reaches ash and updates login status.
+ SessionControllerClient::FlushForTesting();
SetShowAccessibilityOptionsInSystemTrayMenu(false);
@@ -594,6 +599,8 @@ IN_PROC_BROWSER_TEST_P(TrayAccessibilityTest, ShowMenuWithShowMenuOption) {
session_manager::SessionManager::Get()->CreateSession(
AccountId::FromUserEmail("owner@invalid.domain"), "owner@invalid.domain");
session_manager::SessionManager::Get()->SessionStarted();
+ // Flush to ensure the session state reaches ash and updates login status.
+ SessionControllerClient::FlushForTesting();
SetShowAccessibilityOptionsInSystemTrayMenu(true);
@@ -1417,7 +1424,8 @@ IN_PROC_BROWSER_TEST_P(TrayAccessibilityTest, CheckMenuVisibilityOnDetailMenu) {
session_manager::SessionManager::Get()->SetSessionState(
session_manager::SessionState::LOGIN_SECONDARY);
- base::RunLoop().RunUntilIdle(); // Flush session state to ash.
+ // Flush to ensure the session state reaches ash and updates login status.
+ SessionControllerClient::FlushForTesting();
SetLoginStatus(ash::LoginStatus::USER);
EXPECT_TRUE(CreateDetailedMenu());
EXPECT_TRUE(IsSpokenFeedbackMenuShownOnDetailMenu());
« no previous file with comments | « chrome/browser/chromeos/power/login_lock_state_notifier.cc ('k') | chrome/browser/ui/ash/session_controller_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698