src/objects.h - Issue 279773002: Fix Array.prototype.push and Array.prototype.unshift for read-only length.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects.h

Issue 279773002: Fix Array.prototype.push and Array.prototype.unshift for read-only length. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Whitespace Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/objects.h

diff --git a/src/objects.h b/src/objects.h

index d642e1e7da88b4f57bf49f79b485031f771a1ef3..1dcb4ee1e642d0ffc5da355b9e09adddcd4d7252 100644

--- a/src/objects.h

+++ b/src/objects.h

@@ -10337,6 +10337,10 @@ class JSArray: public JSObject {

uint32_t index,

Handle<Object> value);

+ static bool IsReadOnlyLengthDescriptor(Handle<Map> jsarray_map);

+ static bool WouldChangeReadOnlyLength(Handle<JSArray> array, uint32_t index);

+ static MaybeHandle<Object> ReadOnlyLengthError(Handle<JSArray> array);

// Initialize the array with the given capacity. The function may

// fail due to out-of-memory situations, but only if the requested

// capacity is non-zero.

« no previous file with comments | « src/ic.cc ('k') | src/objects.cc » ('j') | no next file with comments »