src/hydrogen.cc - Issue 279773002: Fix Array.prototype.push and Array.prototype.unshift for read-only length.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/hydrogen.cc

Issue 279773002: Fix Array.prototype.push and Array.prototype.unshift for read-only length. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Address comments Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/hydrogen.cc

diff --git a/src/hydrogen.cc b/src/hydrogen.cc

index ee9f8e41676b054dc34a7797677e68f3a940e6ef..cfdc0cfba5c780084bbbfb4417dad5a95dd5408f 100644

--- a/src/hydrogen.cc

+++ b/src/hydrogen.cc

@@ -7789,6 +7789,7 @@ bool HOptimizedGraphBuilder::TryInlineBuiltinMethodCall(

ElementsKind elements_kind = receiver_map->elements_kind();

if (!IsFastElementsKind(elements_kind)) return false;

if (receiver_map->is_observed()) return false;

+ if (JSArray::IsReadOnlyLengthDescriptor(receiver_map)) return false;

ASSERT(receiver_map->is_extensible());

// If there may be elements accessors in the prototype chain, the fast

« src/builtins.cc ('K') | « src/builtins.cc ('k') | src/ic.cc » ('j') | src/ic.cc » ('J')