Fix Array.prototype.push and Array.prototype.unshift for read-only length.

src/array.js

Index: src/array.js
diff --git a/src/array.js b/src/array.js
index dcaf0f40080e84db790321726bd9c67244eca5be..6f649e1f39bfe7dd7e8f8b8508ede2e35ab4d632 100644
--- a/src/array.js
+++ b/src/array.js
@@ -603,7 +603,9 @@ function ObservedArrayUnshift() {
 
   try {
     BeginPerformSplice(this);
-    SimpleMove(this, 0, 0, len, num_arguments);
+    if (len > 0) {

[Michael Starzinger, 2014/05/21 12:34:36]

As discussed offline: IMHO SimpleMove shouldn't have any side-effects if len ==
0 here. So this check should be obsolete.

[ulan, 2014/05/21 14:52:22]

Done.

+      SimpleMove(this, 0, 0, len, num_arguments);
+    }
     for (var i = 0; i < num_arguments; i++) {
       this[i] = %_Arguments(i);
     }
@@ -628,10 +630,12 @@ function ArrayUnshift(arg1) {  // length == 1
   var num_arguments = %_ArgumentsLength();
   var is_sealed = ObjectIsSealed(array);
 
-  if (IS_ARRAY(array) && !is_sealed) {
-    SmartMove(array, 0, 0, len, num_arguments);
-  } else {
-    SimpleMove(array, 0, 0, len, num_arguments);
+  if (len > 0) {
+    if (IS_ARRAY(array) && !is_sealed) {

[Michael Starzinger, 2014/05/21 12:34:36]

Likewise, for len == 0 should do the right thing here, so can we restructure
this as follows instead?

if (IS_ARRAY(array) && !is_sealed && len > 0) {
  SmartMove(array, 0, 0, len, num_arguments);
} else {
  SimpleMove(array, 0, 0, len, num_arguments);
}

[ulan, 2014/05/21 14:52:22]

Done.

+      SmartMove(array, 0, 0, len, num_arguments);
+    } else {
+      SimpleMove(array, 0, 0, len, num_arguments);
+    }
   }
 
   for (var i = 0; i < num_arguments; i++) {