Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Unified Diff: chrome/browser/extensions/install_signer.cc

Issue 2797683002: Network traffic annotation added to install_signer. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/install_signer.cc
diff --git a/chrome/browser/extensions/install_signer.cc b/chrome/browser/extensions/install_signer.cc
index 065a544b3c85799c3059c3f9dd9d312284f8de92..78d3fc3ceb79d47525421fd07542bdaa6f6cb5d4 100644
--- a/chrome/browser/extensions/install_signer.cc
+++ b/chrome/browser/extensions/install_signer.cc
@@ -30,6 +30,7 @@
#include "crypto/secure_hash.h"
#include "crypto/sha2.h"
#include "crypto/signature_verifier.h"
+#include "net/traffic_annotation/network_traffic_annotation.h"
#include "net/url_request/url_fetcher.h"
#include "net/url_request/url_fetcher_delegate.h"
#include "net/url_request/url_request_context_getter.h"
@@ -373,8 +374,29 @@ void InstallSigner::GetSignature(const SignatureCallback& callback) {
base::Unretained(this));
delegate_.reset(new FetcherDelegate(closure));
+ net::NetworkTrafficAnnotationTag traffic_annotation =
+ net::DefineNetworkTrafficAnnotation("...", R"(
+ semantics {
+ sender: "..."
Devlin 2017/04/19 20:27:07 extension install signer
Ramin Halavati 2017/04/21 05:50:40 Done.
+ description: "..."
Devlin 2017/04/19 20:27:07 Fetches the signatures for installed extensions
Ramin Halavati 2017/04/21 05:50:41 Done.
+ trigger: "..."
Devlin 2017/04/19 20:27:07 Chrome detects an extension that requires installa
Ramin Halavati 2017/04/21 05:50:41 Done.
+ data: "..."
Devlin 2017/04/19 20:27:07 The ids of the extensions that need to be verified
Ramin Halavati 2017/04/21 05:50:41 Done.
+ destination: WEBSITE/GOOGLE_OWNED_SERVICE/OTHER
Devlin 2017/04/19 20:27:07 GOOGLE_OWNED_SERVICE
Ramin Halavati 2017/04/21 05:50:40 Done.
+ }
+ policy {
+ cookies_allowed: false/true
+ cookies_store: "..."
+ setting: "..."
+ chrome_policy {
Devlin 2017/04/19 20:27:07 This setting can be disabled by not installing any
Ramin Halavati 2017/04/21 05:50:41 Done.
+ [POLICY_NAME] {
+ policy_options {mode: MANDATORY/RECOMMENDED/UNSET}
+ [POLICY_NAME]: ... //(value to disable it)
+ }
+ }
+ policy_exception_justification: "..."
+ })");
url_fetcher_ = net::URLFetcher::Create(GetBackendUrl(), net::URLFetcher::POST,
- delegate_.get());
+ delegate_.get(), traffic_annotation);
url_fetcher_->SetRequestContext(context_getter_);
// The request protocol is JSON of the form:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698