Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Unified Diff: test/cctest/wasm/test-run-wasm-module.cc

Issue 2797653002: [wasm] Module Builder v8 API: bytes passed in are owned by caller. (Closed)
Patch Set: . Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/api.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/wasm/test-run-wasm-module.cc
diff --git a/test/cctest/wasm/test-run-wasm-module.cc b/test/cctest/wasm/test-run-wasm-module.cc
index c81d651c53652feab8d2114a6416185656445b32..e52f0d80af37611a7e9aea680d8df22cf5ffbfd3 100644
--- a/test/cctest/wasm/test-run-wasm-module.cc
+++ b/test/cctest/wasm/test-run-wasm-module.cc
@@ -464,9 +464,9 @@ TEST(ModuleBuilder) {
CreatePayload(buffer.begin() + first_mark, second_mark - first_mark);
std::unique_ptr<const uint8_t[]> third_part =
CreatePayload(buffer.begin() + second_mark, buffer.size() - second_mark);
- builder.OnBytesReceived(std::move(first_part), first_mark);
- builder.OnBytesReceived(std::move(second_part), second_mark - first_mark);
- builder.OnBytesReceived(std::move(third_part), buffer.size() - second_mark);
+ builder.OnBytesReceived(first_part.get(), first_mark);
+ builder.OnBytesReceived(second_part.get(), second_mark - first_mark);
+ builder.OnBytesReceived(third_part.get(), buffer.size() - second_mark);
{
HandleScope scope(i_isolate);
v8::MaybeLocal<v8::WasmCompiledModule> maybe_module = builder.Finish();
@@ -490,7 +490,7 @@ TEST(FailingModuleBuilder) {
v8::WasmModuleObjectBuilder builder(CcTest::isolate());
std::unique_ptr<const uint8_t[]> first_part =
CreatePayload(buffer.begin(), first_mark);
- builder.OnBytesReceived(std::move(first_part), first_mark);
+ builder.OnBytesReceived(first_part.get(), first_mark);
{
HandleScope scope(i_isolate);
v8::MaybeLocal<v8::WasmCompiledModule> maybe_module = builder.Finish();
« no previous file with comments | « src/api.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698