Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2305)

Unified Diff: include/v8.h

Issue 2797653002: [wasm] Module Builder v8 API: bytes passed in are owned by caller. (Closed)
Patch Set: . Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/v8.h
diff --git a/include/v8.h b/include/v8.h
index 14a119f0e85e3be738d9649be869de6085d1c7b6..7d2abb7bf05d0d70b5e5d015ad78bc75f4253f1e 100644
--- a/include/v8.h
+++ b/include/v8.h
@@ -4053,7 +4053,8 @@ class V8_EXPORT WasmCompiledModule : public Object {
class V8_EXPORT WasmModuleObjectBuilder final {
public:
WasmModuleObjectBuilder(Isolate* isolate) : isolate_(isolate) {}
- void OnBytesReceived(std::unique_ptr<const uint8_t[]>&& bytes, size_t size);
+ // The buffer passed into OnBytesReceived is owned by the caller.
+ void OnBytesReceived(const uint8_t*, size_t size);
MaybeLocal<WasmCompiledModule> Finish();
private:
« no previous file with comments | « no previous file | src/api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698