Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 279763002: Support a negation pseudo-class, :not(), in <content select> (Closed)

Created:
6 years, 7 months ago by hayato
Modified:
6 years, 6 months ago
Reviewers:
esprehn, dglazkov, kochi
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Visibility:
Public.

Description

Support a negation pseudo-class, :not(), in matching criteria of content insertion points. The spec: http://w3c.github.io/webcomponents/spec/shadow/#satisfying-matching-criteria BUG=370670 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174929

Patch Set 1 #

Patch Set 2 : Update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+254 lines, -32 lines) Patch
M LayoutTests/fast/dom/shadow/content-selector-query.html View 1 2 chunks +50 lines, -6 lines 0 comments Download
M LayoutTests/fast/dom/shadow/content-selector-query-expected.txt View 1 2 chunks +185 lines, -23 lines 0 comments Download
M Source/core/css/CSSSelector.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/HTMLContentElement.cpp View 1 2 chunks +8 lines, -3 lines 0 comments Download
M Source/core/testing/InternalSettings.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/testing/InternalSettings.cpp View 1 3 chunks +7 lines, -0 lines 0 comments Download
M Source/core/testing/InternalSettings.idl View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
hayato
The patch is not ready for a review. I have to update the Layout tests. ...
6 years, 7 months ago (2014-05-09 08:01:34 UTC) #1
hayato
Let me resume this work.
6 years, 7 months ago (2014-05-22 11:14:56 UTC) #2
hayato
The patch is wrong. Looks like ':not()' has never been supported in <content select> in ...
6 years, 7 months ago (2014-05-23 07:49:35 UTC) #3
hayato
The patch is ready for review. PTAL.
6 years, 7 months ago (2014-05-27 08:41:19 UTC) #4
dglazkov
lgtm
6 years, 7 months ago (2014-05-27 17:15:24 UTC) #5
hayato
The CQ bit was checked by hayato@chromium.org
6 years, 6 months ago (2014-05-28 04:16:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hayato@chromium.org/279763002/20001
6 years, 6 months ago (2014-05-28 04:16:51 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-05-28 04:29:49 UTC) #8
Message was sent while issue was closed.
Change committed as 174929

Powered by Google App Engine
This is Rietveld 408576698