Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2900)

Unified Diff: cc/tiles/image_controller.cc

Issue 2797583002: cc: Add color space to image decode caches (Closed)
Patch Set: Fix perf test compile Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/tiles/image_controller.cc
diff --git a/cc/tiles/image_controller.cc b/cc/tiles/image_controller.cc
index ce6968b412df94f44c162414f7bff6f5acf37438..08b2ec208f3b8e514926730666f7875ed430c81f 100644
--- a/cc/tiles/image_controller.cc
+++ b/cc/tiles/image_controller.cc
@@ -183,11 +183,17 @@ ImageController::ImageDecodeRequestId ImageController::QueueImageDecode(
// Generate the next id.
ImageDecodeRequestId id = s_next_image_decode_queue_id_++;
+ // TODO(ccameron): The target color space specified here should match the
+ // target color space that will be used at rasterization time. Leave this
+ // unspecified now, since that will match the rasterization-time color
+ // space while color correct rendering is disabled.
+ gfx::ColorSpace target_color_space;
+
DCHECK(image);
bool is_image_lazy = image->isLazyGenerated();
auto image_bounds = image->bounds();
DrawImage draw_image(std::move(image), image_bounds, kNone_SkFilterQuality,
- SkMatrix::I());
+ SkMatrix::I(), target_color_space);
// Get the tasks for this decode.
scoped_refptr<TileTask> task;

Powered by Google App Engine
This is Rietveld 408576698