Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1029)

Issue 279753002: Focus whole entry name when renaming directories. (Closed)

Created:
6 years, 7 months ago by fukino
Modified:
6 years, 7 months ago
Reviewers:
hirono
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Focus whole entry name when renaming directories. Under current implementation, extension part of entry name (after the last '.') is not focused even when users rename directories. For directories, whole entry name should always be focused. BUG=371676 TEST=manually tested Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269559

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M ui/file_manager/file_manager/foreground/js/file_manager.js View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
fukino
hirono san, PTAL!
6 years, 7 months ago (2014-05-09 08:04:15 UTC) #1
hirono
lgtm!
6 years, 7 months ago (2014-05-09 08:13:03 UTC) #2
fukino
The CQ bit was checked by fukino@chromium.org
6 years, 7 months ago (2014-05-09 08:13:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fukino@chromium.org/279753002/1
6 years, 7 months ago (2014-05-09 08:15:01 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-10 11:39:25 UTC) #5
Message was sent while issue was closed.
Change committed as 269559

Powered by Google App Engine
This is Rietveld 408576698