Fix interstitials on OOPIF-based guests.

chrome/browser/apps/guest_view/web_view_browsertest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <queue>
 #include <set>
 #include <utility>
 
 #include "base/callback_helpers.h"
 #include "base/files/file_util.h"
@@ skipping 33 matching lines @@
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/test/base/ui_test_utils.h"
 #include "components/content_settings/core/browser/host_content_settings_map.h"
 #include "components/guest_view/browser/guest_view_manager.h"
 #include "components/guest_view/browser/guest_view_manager_delegate.h"
 #include "components/guest_view/browser/guest_view_manager_factory.h"
 #include "components/guest_view/browser/test_guest_view_manager.h"
 #include "content/public/browser/ax_event_notification_details.h"
 #include "content/public/browser/gpu_data_manager.h"
 #include "content/public/browser/interstitial_page.h"
-#include "content/public/browser/interstitial_page_delegate.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/render_process_host.h"
 #include "content/public/browser/render_widget_host.h"
 #include "content/public/browser/render_widget_host_view.h"
 #include "content/public/browser/web_contents_delegate.h"
 #include "content/public/common/child_process_host.h"
 #include "content/public/common/content_features.h"
 #include "content/public/common/content_switches.h"
 #include "content/public/test/browser_test_utils.h"
 #include "content/public/test/download_test_observer.h"
 #include "content/public/test/fake_speech_recognition_manager.h"
 #include "content/public/test/test_navigation_observer.h"
 #include "content/public/test/test_renderer_host.h"
 #include "content/public/test/test_utils.h"
 #include "extensions/browser/api/declarative/rules_registry.h"
 #include "extensions/browser/api/declarative/rules_registry_service.h"
 #include "extensions/browser/api/declarative/test_rules_registry.h"
 #include "extensions/browser/api/declarative_webrequest/webrequest_constants.h"
 #include "extensions/browser/api/extensions_api_client.h"
 #include "extensions/browser/app_window/native_app_window.h"
 #include "extensions/browser/guest_view/web_view/web_view_guest.h"
 #include "extensions/common/extension.h"
 #include "extensions/common/extensions_client.h"
 #include "extensions/test/extension_test_message_listener.h"
 #include "media/base/media_switches.h"
 #include "net/test/embedded_test_server/embedded_test_server.h"
 #include "net/test/embedded_test_server/http_request.h"
 #include "net/test/embedded_test_server/http_response.h"
 #include "ppapi/features/features.h"
+#include "third_party/WebKit/public/platform/WebMouseEvent.h"
 #include "ui/aura/env.h"
 #include "ui/aura/window.h"
 #include "ui/compositor/compositor.h"
 #include "ui/compositor/compositor_observer.h"
 #include "ui/display/display_switches.h"
 #include "ui/events/gesture_detection/gesture_configuration.h"
 #include "ui/gl/gl_switches.h"
 #include "ui/views/view.h"
 #include "ui/views/widget/widget.h"
 
@@ skipping 23 matching lines @@
 using ui::MenuModel;
 
 namespace {
 const char kEmptyResponsePath[] = "/close-socket";
 const char kRedirectResponsePath[] = "/server-redirect";
 const char kUserAgentRedirectResponsePath[] = "/detect-user-agent";
 const char kCacheResponsePath[] = "/cache-control-response";
 const char kRedirectResponseFullPath[] =
     "/extensions/platform_apps/web_view/shim/guest_redirect.html";
 
-class TestInterstitialPageDelegate : public content::InterstitialPageDelegate {
- public:
-  TestInterstitialPageDelegate() {
-  }
-  ~TestInterstitialPageDelegate() override {}
-  std::string GetHTMLContents() override { return std::string(); }
-};
-
 class WebContentsHiddenObserver : public content::WebContentsObserver {
  public:
   WebContentsHiddenObserver(content::WebContents* web_contents,
                             const base::Closure& hidden_callback)
       : WebContentsObserver(web_contents),
         hidden_callback_(hidden_callback),
         hidden_observed_(false) {
   }
 
   // WebContentsObserver.
@@ skipping 539 matching lines @@
     content::Source<content::NavigationController> source =
         guest_observer.source();
     EXPECT_TRUE(source->GetWebContents()->GetRenderProcessHost()->
         IsForGuestsOnly());
 
     content::WebContents* guest_web_contents = source->GetWebContents();
     return guest_web_contents;
   }
 
   // Helper to load interstitial page in a <webview>.
-  void InterstitialTeardownTestHelper() {
+  void InterstitialTestHelper() {
     // Start a HTTPS server so we can load an interstitial page inside guest.
     net::EmbeddedTestServer https_server(net::EmbeddedTestServer::TYPE_HTTPS);
     https_server.SetSSLConfig(net::EmbeddedTestServer::CERT_MISMATCHED_NAME);
     https_server.ServeFilesFromSourceDirectory("chrome/test/data");
     ASSERT_TRUE(https_server.Start());
 
     net::HostPortPair host_and_port = https_server.host_port_pair();
 
     LoadAndLaunchPlatformApp("web_view/interstitial_teardown",
                              "EmbedderLoaded");
@@ skipping 985 matching lines @@
              "web_view/shim",
              NO_TEST_SERVER);
 }
 
 IN_PROC_BROWSER_TEST_P(WebViewSizeTest, Shim_TestResizeWebviewResizesContent) {
   TestHelper("testResizeWebviewResizesContent",
              "web_view/shim",
              NO_TEST_SERVER);
 }
 
+// Test makes sure that interstitial pages renders in <webview>.
+IN_PROC_BROWSER_TEST_P(WebViewTest, InterstitialPage) {
+  // This test tests that a inner WebContents' InterstitialPage is properly
+  // connected to an outer WebContents through a CrossProcessFrameConnector, it
+  // doesn't make sense for BrowserPlugin based guests.
+  if (!base::FeatureList::IsEnabled(::features::kGuestViewCrossProcessFrames))
+    return;
+
+  InterstitialTestHelper();
+
+  content::WebContents* guest_web_contents =
+      GetGuestViewManager()->WaitForSingleGuestCreated();
+
+  EXPECT_TRUE(guest_web_contents->ShowingInterstitialPage());
+  EXPECT_TRUE(guest_web_contents->GetInterstitialPage()
+                  ->GetMainFrame()
+                  ->GetView()
+                  ->IsShowing());
+  EXPECT_TRUE(content::IsInnerInterstitialPageConnected(
+      guest_web_contents->GetInterstitialPage()));
+}
+
+// Test makes sure that interstitial pages are registered in the
+// RenderWidgetHostInputEventRouter when inside a <webview>.
+IN_PROC_BROWSER_TEST_P(WebViewTest, InterstitialPageRouteEvents) {
+  // This test tests that a inner WebContents' InterstitialPage is properly
+  // connected to an outer WebContents through a CrossProcessFrameConnector, it
+  // doesn't make sense for BrowserPlugin based guests.
+  if (!base::FeatureList::IsEnabled(::features::kGuestViewCrossProcessFrames))
+    return;
+
+  InterstitialTestHelper();
+
+  content::WebContents* outer_web_contents = GetFirstAppWindowWebContents();
+  content::WebContents* guest_web_contents =
+      GetGuestViewManager()->WaitForSingleGuestCreated();
+  content::InterstitialPage* interstitial_page =
+      guest_web_contents->GetInterstitialPage();
+
+  std::vector<content::RenderWidgetHostView*> hosts =
+      content::GetInputEventRouterRenderWidgetHostViews(outer_web_contents);
+  EXPECT_TRUE(std::find(hosts.begin(), hosts.end(),
+                        interstitial_page->GetMainFrame()->GetView()) !=
+              hosts.end());
+}
+
+// Test makes sure that interstitial pages will receive input events and can be
+// focused.
+IN_PROC_BROWSER_TEST_P(WebViewTest, InterstitialPageFocusedWidget) {
+  // This test tests that a inner WebContents' InterstitialPage is properly
+  // connected to an outer WebContents through a CrossProcessFrameConnector, it
+  // doesn't make sense for BrowserPlugin based guests.
+  if (!base::FeatureList::IsEnabled(::features::kGuestViewCrossProcessFrames))
+    return;
+
+  InterstitialTestHelper();
+
+  content::WebContents* outer_web_contents = GetFirstAppWindowWebContents();
+  content::WebContents* guest_web_contents =
+      GetGuestViewManager()->WaitForSingleGuestCreated();
+  content::InterstitialPage* interstitial_page =
+      guest_web_contents->GetInterstitialPage();
+  content::RenderFrameHost* interstitial_main_frame =
+      interstitial_page->GetMainFrame();
+  content::RenderWidgetHost* interstitial_widget =
+      interstitial_main_frame->GetRenderViewHost()->GetWidget();
+
+  content::WaitForChildFrameSurfaceReady(interstitial_main_frame);
+
+  EXPECT_NE(interstitial_widget,
+            content::GetFocusedRenderWidgetHost(guest_web_contents));
+  EXPECT_NE(interstitial_widget,
+            content::GetFocusedRenderWidgetHost(outer_web_contents));
+
+  // Send mouse down.
+  blink::WebMouseEvent event;
+  event.button = blink::WebPointerProperties::Button::kLeft;
+  event.SetType(blink::WebInputEvent::kMouseDown);
+  event.SetPositionInWidget(10, 10);
+  content::RouteMouseEvent(outer_web_contents, &event);
+
+  // Wait a frame.
+  content::MainThreadFrameObserver observer(interstitial_widget);
+  observer.Wait();
+
+  // Send mouse up.
+  event.SetType(blink::WebInputEvent::kMouseUp);
+  event.SetPositionInWidget(10, 10);
+  content::RouteMouseEvent(outer_web_contents, &event);
+
+  // Wait another frame.
+  observer.Wait();
+
+  EXPECT_EQ(interstitial_widget,
+            content::GetFocusedRenderWidgetHost(guest_web_contents));
+  EXPECT_EQ(interstitial_widget,
+            content::GetFocusedRenderWidgetHost(outer_web_contents));
+}
+
 // This test makes sure the browser process does not crash if app is closed
 // while an interstitial page is being shown in guest.
 IN_PROC_BROWSER_TEST_P(WebViewTest, InterstitialTeardown) {
-  InterstitialTeardownTestHelper();
+  InterstitialTestHelper();
 
   // Now close the app while interstitial page being shown in guest.
   extensions::AppWindow* window = GetFirstAppWindow();
   window->GetBaseWindow()->Close();
 }
 
 // This test makes sure the browser process does not crash if browser is shut
 // down while an interstitial page is being shown in guest.
 // Flaky. http://crbug.com/627962.
 IN_PROC_BROWSER_TEST_P(WebViewTest,
                        DISABLED_InterstitialTeardownOnBrowserShutdown) {
-  InterstitialTeardownTestHelper();
+  InterstitialTestHelper();
 
   // Now close the app while interstitial page being shown in guest.
   extensions::AppWindow* window = GetFirstAppWindow();
   window->GetBaseWindow()->Close();
 
   // InterstitialPage is not destroyed immediately, so the
   // RenderWidgetHostViewGuest for it is still there, closing all
   // renderer processes will cause the RWHVGuest's RenderProcessGone()
   // shutdown path to be exercised.
   chrome::CloseAllBrowsers();
@@ skipping 2302 matching lines @@
                        ClosingChromeSignInShouldNotCrash) {
   GURL signin_url{"chrome://chrome-signin"};
 
   AddTabAtIndex(0, signin_url, ui::PAGE_TRANSITION_TYPED);
   AddTabAtIndex(1, signin_url, ui::PAGE_TRANSITION_TYPED);
   WaitForWebViewInDom();
 
   chrome::CloseTab(browser());
 }
 #endif