Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(646)

Unified Diff: third_party/WebKit/Source/modules/accessibility/AXObject.cpp

Issue 2797463002: Added some more roles to the list of roles that calculate their names from content. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/accessibility/AXObject.cpp
diff --git a/third_party/WebKit/Source/modules/accessibility/AXObject.cpp b/third_party/WebKit/Source/modules/accessibility/AXObject.cpp
index 1671402dcd5fb2400ead7a92e9c4bf9a26b00e83..564f40a06fe3f375bf400af26e9bf46957b11b9e 100644
--- a/third_party/WebKit/Source/modules/accessibility/AXObject.cpp
+++ b/third_party/WebKit/Source/modules/accessibility/AXObject.cpp
@@ -1718,9 +1718,12 @@ bool AXObject::includesARIAWidgetRole(const String& role) {
}
bool AXObject::nameFromContents() const {
+ // ARIA 1.1, section 5.2.7.5.
switch (roleValue()) {
case ButtonRole:
+ case CellRole:
case CheckBoxRole:
+ case ColumnHeaderRole:
case DirectoryRole:
case DisclosureTriangleRole:
case HeadingRole:
@@ -1734,12 +1737,16 @@ bool AXObject::nameFromContents() const {
case MenuListOptionRole:
case PopUpButtonRole:
case RadioButtonRole:
+ case RowRole:
dmazzoni 2017/04/03 17:10:40 Row may be problematic. Wouldn't that give the acc
+ case RowHeaderRole:
case StaticTextRole:
case StatusRole:
case SwitchRole:
case TabRole:
case ToggleButtonRole:
+ case TreeRole:
case TreeItemRole:
+ case UserInterfaceTooltipRole:
return true;
default:
return false;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698