Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Unified Diff: services/ui/surfaces/mojo_frame_sink_manager.h

Issue 2797453002: Rename DisplayCompositor to MojoFrameSinkManager. (Closed)
Patch Set: Fix msw@ comments. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « services/ui/surfaces/display_provider.h ('k') | services/ui/surfaces/mojo_frame_sink_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: services/ui/surfaces/mojo_frame_sink_manager.h
diff --git a/services/ui/surfaces/display_compositor.h b/services/ui/surfaces/mojo_frame_sink_manager.h
similarity index 74%
rename from services/ui/surfaces/display_compositor.h
rename to services/ui/surfaces/mojo_frame_sink_manager.h
index a14704d40094f9e40dcac41a1764243db8fca70d..55741c90dae44b99fc393b30e8f541ba095c07bd 100644
--- a/services/ui/surfaces/display_compositor.h
+++ b/services/ui/surfaces/mojo_frame_sink_manager.h
@@ -2,8 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef SERVICES_UI_SURFACES_DISPLAY_COMPOSITOR_H_
-#define SERVICES_UI_SURFACES_DISPLAY_COMPOSITOR_H_
+#ifndef SERVICES_UI_SURFACES_MOJO_FRAME_SINK_MANAGER_H_
+#define SERVICES_UI_SURFACES_MOJO_FRAME_SINK_MANAGER_H_
#include <stdint.h>
@@ -12,7 +12,7 @@
#include "base/macros.h"
#include "base/threading/thread_checker.h"
-#include "cc/ipc/display_compositor.mojom.h"
+#include "cc/ipc/frame_sink_manager.mojom.h"
#include "cc/surfaces/frame_sink_id.h"
#include "cc/surfaces/surface_manager.h"
#include "cc/surfaces/surface_observer.h"
@@ -24,24 +24,26 @@ namespace ui {
class DisplayProvider;
-// The DisplayCompositor object is an object global to the Window Server app
-// that holds the SurfaceServer and allocates new Surfaces namespaces.
-// This object lives on the main thread of the Window Server.
-// TODO(rjkroege, fsamuel): This object will need to change to support multiple
-// displays.
-class DisplayCompositor
+// MojoFrameSinkManager manages state associated with CompositorFrameSinks. It
+// provides a Mojo interface to create CompositorFrameSinks, manage BeginFrame
msw 2017/04/03 20:07:34 nit: 'manages' here and on the next line?
kylechar 2017/04/03 20:32:06 Done.
+// hierarchy and managed surface lifetime.
+//
+// This is intended to created in the viz or GPU process. For mus+ash this will
msw 2017/04/03 20:07:34 nit: 'be created'? Is 'viz' the appropriate proces
kylechar 2017/04/03 20:32:06 Changed. Also, yep, basically GPU process => viz p
+// be true after the mus process split. For non-mus Chrome this will be created
+// in the browser process, at least until GPU implementations can be unified.
+class MojoFrameSinkManager
: public cc::SurfaceObserver,
public display_compositor::GpuCompositorFrameSinkDelegate,
- public cc::mojom::DisplayCompositor {
+ public cc::mojom::FrameSinkManager {
public:
- DisplayCompositor(DisplayProvider* display_provider,
- cc::mojom::DisplayCompositorRequest request,
- cc::mojom::DisplayCompositorClientPtr client);
- ~DisplayCompositor() override;
+ MojoFrameSinkManager(DisplayProvider* display_provider,
+ cc::mojom::FrameSinkManagerRequest request,
+ cc::mojom::FrameSinkManagerClientPtr client);
+ ~MojoFrameSinkManager() override;
cc::SurfaceManager* manager() { return &manager_; }
- // cc::mojom::DisplayCompositor implementation:
+ // cc::mojom::MojoFrameSinkManager implementation:
void CreateRootCompositorFrameSink(
const cc::FrameSinkId& frame_sink_id,
gpu::SurfaceHandle surface_handle,
@@ -97,12 +99,12 @@ class DisplayCompositor
base::ThreadChecker thread_checker_;
- cc::mojom::DisplayCompositorClientPtr client_;
- mojo::Binding<cc::mojom::DisplayCompositor> binding_;
+ cc::mojom::FrameSinkManagerClientPtr client_;
+ mojo::Binding<cc::mojom::FrameSinkManager> binding_;
- DISALLOW_COPY_AND_ASSIGN(DisplayCompositor);
+ DISALLOW_COPY_AND_ASSIGN(MojoFrameSinkManager);
};
} // namespace ui
-#endif // SERVICES_UI_SURFACES_DISPLAY_COMPOSITOR_H_
+#endif // SERVICES_UI_SURFACES_MOJO_FRAME_SINK_MANAGER_H_
« no previous file with comments | « services/ui/surfaces/display_provider.h ('k') | services/ui/surfaces/mojo_frame_sink_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698