Rename DisplayCompositor to MojoFrameSinkManager.

services/ui/surfaces/mojo_frame_sink_manager.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef SERVICES_UI_SURFACES_DISPLAY_COMPOSITOR_H_
-#define SERVICES_UI_SURFACES_DISPLAY_COMPOSITOR_H_
+#ifndef SERVICES_UI_SURFACES_MOJO_FRAME_SINK_MANAGER_H_
+#define SERVICES_UI_SURFACES_MOJO_FRAME_SINK_MANAGER_H_
 
 #include <stdint.h>
 
 #include <memory>
 #include <unordered_map>
 
 #include "base/macros.h"
 #include "base/threading/thread_checker.h"
-#include "cc/ipc/display_compositor.mojom.h"
+#include "cc/ipc/frame_sink_manager.mojom.h"
 #include "cc/surfaces/frame_sink_id.h"
 #include "cc/surfaces/surface_manager.h"
 #include "cc/surfaces/surface_observer.h"
 #include "components/display_compositor/gpu_compositor_frame_sink_delegate.h"
 #include "gpu/ipc/common/surface_handle.h"
 #include "mojo/public/cpp/bindings/binding.h"
 
 namespace ui {
 
 class DisplayProvider;
 
-// The DisplayCompositor object is an object global to the Window Server app
+// The MojoFrameSinkManager object is an object global to the Window Server app
 // that holds the SurfaceServer and allocates new Surfaces namespaces.
 // This object lives on the main thread of the Window Server.
 // TODO(rjkroege, fsamuel): This object will need to change to support multiple
 // displays.
-class DisplayCompositor
+class MojoFrameSinkManager

[msw, 2017/04/03 19:22:13]

q: Why use Mojo in this name? Maybe explain in comment?

[kylechar, 2017/04/03 19:54:15]

There is a cc::FrameSinkManager already :( MojoFrameSinkManager was the best
compromise. I'll rewrite the class comment since I'm changing other comments in
this CL too.

[danakj, 2017/04/03 19:55:15]

Also this is managing MojoCompositorFrameSink, so it's literally a manager of
Mojo*FrameSink.

[msw, 2017/04/03 20:07:34]

Then I'd ask the same question of MojoCompositorFrameSink. It doesn't make sense
if every Mojo interface in prefixed with 'Mojo'. I guess the idea in this case
is "it's just like that other thing we have, but this one uses Mojo."

[danakj, 2017/04/03 20:11:15]

We had that discussion on the CL that introduced the name, which you can find if
you want. But yeah there is a cc API and we made a Mojo api like it, and I did
not like depending on a namespace only to differentiate.

     : public cc::SurfaceObserver,
       public display_compositor::GpuCompositorFrameSinkDelegate,
-      public cc::mojom::DisplayCompositor {
+      public cc::mojom::FrameSinkManager {
  public:
-  DisplayCompositor(DisplayProvider* display_provider,
-                    cc::mojom::DisplayCompositorRequest request,
-                    cc::mojom::DisplayCompositorClientPtr client);
-  ~DisplayCompositor() override;
+  MojoFrameSinkManager(DisplayProvider* display_provider,
+                       cc::mojom::FrameSinkManagerRequest request,
+                       cc::mojom::FrameSinkManagerClientPtr client);
+  ~MojoFrameSinkManager() override;
 
   cc::SurfaceManager* manager() { return &manager_; }
 
-  // cc::mojom::DisplayCompositor implementation:
+  // cc::mojom::MojoFrameSinkManager implementation:
   void CreateRootCompositorFrameSink(
       const cc::FrameSinkId& frame_sink_id,
       gpu::SurfaceHandle surface_handle,
       cc::mojom::MojoCompositorFrameSinkAssociatedRequest request,
       cc::mojom::MojoCompositorFrameSinkPrivateRequest private_request,
       cc::mojom::MojoCompositorFrameSinkClientPtr client,
       cc::mojom::DisplayPrivateAssociatedRequest display_private_request)
       override;
   void CreateCompositorFrameSink(
       const cc::FrameSinkId& frame_sink_id,
@@ skipping 35 matching lines @@
   // Provides a cc::Display for CreateRootCompositorFrameSink().
   DisplayProvider* const display_provider_;
 
   std::unordered_map<cc::FrameSinkId,
                      std::unique_ptr<cc::mojom::MojoCompositorFrameSink>,
                      cc::FrameSinkIdHash>
       compositor_frame_sinks_;
 
   base::ThreadChecker thread_checker_;
 
-  cc::mojom::DisplayCompositorClientPtr client_;
-  mojo::Binding<cc::mojom::DisplayCompositor> binding_;
+  cc::mojom::FrameSinkManagerClientPtr client_;
+  mojo::Binding<cc::mojom::FrameSinkManager> binding_;
 
-  DISALLOW_COPY_AND_ASSIGN(DisplayCompositor);
+  DISALLOW_COPY_AND_ASSIGN(MojoFrameSinkManager);
 };
 
 }  // namespace ui
 
-#endif  //  SERVICES_UI_SURFACES_DISPLAY_COMPOSITOR_H_
+#endif  //  SERVICES_UI_SURFACES_MOJO_FRAME_SINK_MANAGER_H_