Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issue 2797443008: Reapply "Add "load from .dill" file capability and run a white-box test."" (Closed)

Created:
3 years, 8 months ago by Emily Fortuna
Modified:
3 years, 8 months ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org, sra1
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Reapply "Add "load from .dill" file capability and run a white-box test."" This reverts commit 8febfff78439a98930306855871c325dd5b8d784. BUG= R=jmesserly@google.com Committed: https://github.com/dart-lang/sdk/commit/b7b37140860884fc6b0847d3e3c4f8f3684f5593

Patch Set 1 #

Patch Set 2 : take two #

Unified diffs Side-by-side diffs Delta from patch set Stats (+282 lines, -42 lines) Patch
M pkg/compiler/lib/src/commandline_options.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 1 7 chunks +15 lines, -11 lines 0 comments Download
M pkg/compiler/lib/src/dart2js.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/dump_info.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/mirrors_analysis.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/kernel/kernel.dart View 1 2 chunks +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/kernel/world_builder.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/library_loader.dart View 11 chunks +146 lines, -19 lines 0 comments Download
M pkg/compiler/lib/src/options.dart View 7 chunks +10 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/serialization/task.dart View 4 chunks +4 lines, -3 lines 0 comments Download
M pkg/compiler/tool/perf.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/analyze_unused_dart2js_test.dart View 2 chunks +3 lines, -1 line 0 comments Download
A tests/compiler/dart2js/dill_loader_test.dart View 1 chunk +85 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/memory_compiler.dart View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Emily Fortuna
3 years, 8 months ago (2017-04-05 18:20:35 UTC) #2
Jennifer Messerly
LGTM! Emily and I just looked into this ... seems dart2js is running strong mode ...
3 years, 8 months ago (2017-04-05 18:29:09 UTC) #3
Emily Fortuna
On 2017/04/05 18:29:09, Jennifer Messerly wrote: > LGTM! Emily and I just looked into this ...
3 years, 8 months ago (2017-04-05 18:38:36 UTC) #4
Emily Fortuna
3 years, 8 months ago (2017-04-05 18:40:58 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
b7b37140860884fc6b0847d3e3c4f8f3684f5593 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698