Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Unified Diff: pkg/dev_compiler/test/codegen_expected/node_modules.js

Issue 2797443007: fix #29182, generate top level const fields lazily (Closed)
Patch Set: fix Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/dev_compiler/test/codegen_expected/node_modules.js
diff --git a/pkg/dev_compiler/test/codegen_expected/node_modules.js b/pkg/dev_compiler/test/codegen_expected/node_modules.js
index 4d542183f0118c6e9a53c05aefc83aeaf33f3fb1..0425cf75235336328bf338ac73f7569ca69a484b 100644
--- a/pkg/dev_compiler/test/codegen_expected/node_modules.js
+++ b/pkg/dev_compiler/test/codegen_expected/node_modules.js
@@ -29,18 +29,23 @@ dart.fn(node_modules.f, VoidTodynamic());
node_modules._f = function() {
};
dart.fn(node_modules._f, VoidTodynamic());
-node_modules.constant = "abc";
-node_modules.finalConstant = "abc";
dart.defineLazy(node_modules, {
+ get constant() {
+ return "abc";
+ },
+ get finalConstant() {
+ return "abc";
+ },
get lazy() {
return dart.fn(() => {
core.print('lazy');
return "abc";
}, VoidToString())();
- }
-});
-node_modules.mutable = "abc";
-dart.defineLazy(node_modules, {
+ },
+ get mutable() {
+ return "abc";
+ },
+ set mutable(_) {},
get lazyMutable() {
return dart.fn(() => {
core.print('lazyMutable');

Powered by Google App Engine
This is Rietveld 408576698