Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3286)

Unified Diff: chrome/app/chrome_crash_reporter_client_win.cc

Issue 2797433002: Include Google Update integration details in crash keys and about:version. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/chrome_browser_main_win.cc » ('j') | chrome/browser/ui/webui/version_ui.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/app/chrome_crash_reporter_client_win.cc
diff --git a/chrome/app/chrome_crash_reporter_client_win.cc b/chrome/app/chrome_crash_reporter_client_win.cc
index 8257769482df2981b25e28624aa1b99ccec08fc3..b0ddb00c47e05443c0b180044cd5570084bf04a5 100644
--- a/chrome/app/chrome_crash_reporter_client_win.cc
+++ b/chrome/app/chrome_crash_reporter_client_win.cc
@@ -45,6 +45,11 @@ constexpr char kExtensionID[] = "extension-%" PRIuS;
constexpr char kShutdownType[] = "shutdown-type";
constexpr char kBrowserUnpinTrace[] = "browser-unpin-trace";
+// Registry values used to determine Chrome's update channel; see
+// https://crbug.com/579504.
+constexpr char kApValue[] = "ap";
+constexpr char kCohortName[] = "cohort-name";
+
constexpr char kGPUVendorID[] = "gpu-venid";
constexpr char kGPUDeviceID[] = "gpu-devid";
constexpr char kGPUDriverVersion[] = "gpu-driver";
@@ -100,6 +105,8 @@ size_t RegisterCrashKeysHelper() {
{kNumExtensionsCount, kSmallSize},
{kShutdownType, kSmallSize},
{kBrowserUnpinTrace, kMediumSize},
+ {kApValue, kSmallSize},
+ {kCohortName, kSmallSize},
{kGPUVendorID, kSmallSize},
{kGPUDeviceID, kSmallSize},
{kGPUDriverVersion, kSmallSize},
« no previous file with comments | « no previous file | chrome/browser/chrome_browser_main_win.cc » ('j') | chrome/browser/ui/webui/version_ui.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698