Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7341)

Unified Diff: chrome/install_static/product_install_details.cc

Issue 2797433002: Include Google Update integration details in crash keys and about:version. (Closed)
Patch Set: components/version_ui/OWNERS now own version_ui_strings.grdp Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/install_static/install_util.cc ('k') | chrome/install_static/product_install_details_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/install_static/product_install_details.cc
diff --git a/chrome/install_static/product_install_details.cc b/chrome/install_static/product_install_details.cc
index cef942b433516289f2f8d2475bb25ea0d47130ba..3e8bec502296492e070c3f1465554634666a72e8 100644
--- a/chrome/install_static/product_install_details.cc
+++ b/chrome/install_static/product_install_details.cc
@@ -128,7 +128,16 @@ std::unique_ptr<PrimaryInstallDetails> MakeProductDetails(
details->set_mode(mode);
details->set_system_level(system_level);
- details->set_channel(DetermineChannel(*mode, system_level));
+
+ // Cache the ap and cohort name values found in the registry for use in crash
+ // keys and in about:version.
+ std::wstring update_ap;
+ std::wstring update_cohort_name;
+ details->set_channel(DetermineChannel(*mode, system_level,
+ false /* !from_binaries */, &update_ap,
+ &update_cohort_name));
+ details->set_update_ap(update_ap);
+ details->set_update_cohort_name(update_cohort_name);
return details;
}
« no previous file with comments | « chrome/install_static/install_util.cc ('k') | chrome/install_static/product_install_details_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698