Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7856)

Unified Diff: chrome/install_static/install_details.h

Issue 2797433002: Include Google Update integration details in crash keys and about:version. (Closed)
Patch Set: components/version_ui/OWNERS now own version_ui_strings.grdp Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/crash_keys.cc ('k') | chrome/install_static/install_util.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/install_static/install_details.h
diff --git a/chrome/install_static/install_details.h b/chrome/install_static/install_details.h
index 4d32ad40664ae4d4bb408775b5416448350390d1..9a9360d55129587977ac856eaa1f3eb382ac0b77 100644
--- a/chrome/install_static/install_details.h
+++ b/chrome/install_static/install_details.h
@@ -49,6 +49,14 @@ class InstallDetails {
// The string length of |channel| (not including the string terminator).
size_t channel_length;
+ // The "ap" (additional parameters) value read from Chrome's ClientState key
+ // during process startup.
+ const wchar_t* update_ap;
+
+ // The "name" value read from Chrome's ClientState\cohort key during process
+ // startup.
+ const wchar_t* update_cohort_name;
+
// True if installed in C:\Program Files{, {x86)}; otherwise, false.
bool system_level;
};
@@ -126,6 +134,22 @@ class InstallDetails {
std::wstring channel() const {
return std::wstring(payload_->channel, payload_->channel_length);
}
+
+ // Returns the "ap" (additional parameters) value read from Chrome's
+ // ClientState key during process startup.
+ std::wstring update_ap() const {
+ return payload_->update_ap ? std::wstring(payload_->update_ap)
+ : std::wstring();
+ }
+
+ // Returns the "name" value read from Chrome's ClientState\cohort key during
+ // process startup.
+ std::wstring update_cohort_name() const {
+ return payload_->update_cohort_name
+ ? std::wstring(payload_->update_cohort_name)
+ : std::wstring();
+ }
+
bool system_level() const { return payload_->system_level; }
// Returns the path to the installation's ClientState registry key. This
@@ -189,12 +213,22 @@ class PrimaryInstallDetails : public InstallDetails {
payload_.channel = channel_.c_str();
payload_.channel_length = channel_.size();
}
+ void set_update_ap(const std::wstring& update_ap) {
+ update_ap_ = update_ap;
+ payload_.update_ap = update_ap_.c_str();
+ }
+ void set_update_cohort_name(const std::wstring& update_cohort_name) {
+ update_cohort_name_ = update_cohort_name;
+ payload_.update_cohort_name = update_cohort_name_.c_str();
+ }
void set_system_level(bool system_level) {
payload_.system_level = system_level;
}
private:
std::wstring channel_;
+ std::wstring update_ap_;
+ std::wstring update_cohort_name_;
Payload payload_ = Payload();
};
« no previous file with comments | « chrome/common/crash_keys.cc ('k') | chrome/install_static/install_util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698