Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1790)

Unified Diff: chrome/browser/chrome_browser_main_win.cc

Issue 2797433002: Include Google Update integration details in crash keys and about:version. (Closed)
Patch Set: components/version_ui/OWNERS now own version_ui_strings.grdp Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/chrome_crash_reporter_client_win.cc ('k') | chrome/browser/ui/webui/version_ui.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chrome_browser_main_win.cc
diff --git a/chrome/browser/chrome_browser_main_win.cc b/chrome/browser/chrome_browser_main_win.cc
index 8dfb2d4f46fef0c341f2e099c9d660559470cc95..6e3fd55a7e6d2c61849f0eadc4b47592c3c4a85f 100644
--- a/chrome/browser/chrome_browser_main_win.cc
+++ b/chrome/browser/chrome_browser_main_win.cc
@@ -57,6 +57,7 @@
#include "chrome/common/env_vars.h"
#include "chrome/grit/chromium_strings.h"
#include "chrome/grit/generated_resources.h"
+#include "chrome/install_static/install_details.h"
#include "chrome/installer/util/browser_distribution.h"
#include "chrome/installer/util/helper.h"
#include "chrome/installer/util/install_util.h"
@@ -321,6 +322,14 @@ int ChromeBrowserMainPartsWin::PreCreateThreads() {
crash_keys::kIsEnterpriseManaged,
base::win::IsEnterpriseManaged() ? "yes" : "no");
+ // Set crash keys containing the registry values used to determine Chrome's
+ // update channel at process startup; see https://crbug.com/579504.
+ const auto& details = install_static::InstallDetails::Get();
+ base::debug::SetCrashKeyValue(crash_keys::kApValue,
+ base::UTF16ToUTF8(details.update_ap()));
+ base::debug::SetCrashKeyValue(
+ crash_keys::kCohortName, base::UTF16ToUTF8(details.update_cohort_name()));
+
int rv = ChromeBrowserMainParts::PreCreateThreads();
// TODO(viettrungluu): why don't we run this earlier?
« no previous file with comments | « chrome/app/chrome_crash_reporter_client_win.cc ('k') | chrome/browser/ui/webui/version_ui.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698