Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 279743002: Improve Array.shift() performance for small arrays. (Closed)

Created:
6 years, 7 months ago by Benedikt Meurer
Modified:
6 years, 7 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Improve Array.shift() performance for small arrays. TEST=mjsunit/array-shift,mjsunit/array-shift2,mjsunit/array-shift3 R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21203

Patch Set 1 #

Patch Set 2 : Style fix #

Patch Set 3 : Fix prototype checks. Add test cases. #

Patch Set 4 : Cosmetic fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+401 lines, -0 lines) Patch
M src/arm/code-stubs-arm.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M src/arm/lithium-arm.h View 2 chunks +16 lines, -0 lines 0 comments Download
M src/arm/lithium-arm.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M src/arm64/lithium-arm64.h View 2 chunks +16 lines, -0 lines 0 comments Download
M src/arm64/lithium-arm64.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M src/code-stubs.h View 2 chunks +31 lines, -0 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 1 1 chunk +80 lines, -0 lines 0 comments Download
M src/hydrogen.cc View 1 2 1 chunk +30 lines, -0 lines 0 comments Download
M src/hydrogen-instructions.h View 2 chunks +46 lines, -0 lines 0 comments Download
M src/hydrogen-instructions.cc View 1 2 3 2 chunks +7 lines, -0 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M src/ia32/lithium-ia32.h View 2 chunks +16 lines, -0 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/objects.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M src/x64/lithium-x64.h View 2 chunks +16 lines, -0 lines 0 comments Download
M src/x64/lithium-x64.cc View 1 chunk +8 lines, -0 lines 0 comments Download
A test/mjsunit/array-shift2.js View 1 2 1 chunk +18 lines, -0 lines 0 comments Download
A test/mjsunit/array-shift3.js View 1 2 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
PTAL
6 years, 7 months ago (2014-05-09 07:33:10 UTC) #1
Sven Panne
lgtm
6 years, 7 months ago (2014-05-09 08:27:02 UTC) #2
Benedikt Meurer
6 years, 7 months ago (2014-05-09 08:28:45 UTC) #3
Message was sent while issue was closed. 
Committed patchset #4 manually as r21203 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698