Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1104)

Unified Diff: third_party/WebKit/Source/platform/fonts/SimpleFontData.h

Issue 2797423005: Always use original ascent/descent for FontMetrics::floatAscent|floatDescent (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/fonts/SimpleFontData.h
diff --git a/third_party/WebKit/Source/platform/fonts/SimpleFontData.h b/third_party/WebKit/Source/platform/fonts/SimpleFontData.h
index 67b194ce87b398f6b859d5ebf7e6629d8a6cca13..b66bc807b5b0d6816bd51ba8ca1d36146b2d98dd 100644
--- a/third_party/WebKit/Source/platform/fonts/SimpleFontData.h
+++ b/third_party/WebKit/Source/platform/fonts/SimpleFontData.h
@@ -69,11 +69,9 @@ class PLATFORM_EXPORT SimpleFontData : public FontData {
static PassRefPtr<SimpleFontData> create(
const FontPlatformData& platformData,
PassRefPtr<CustomFontData> customData = nullptr,
- bool isTextOrientationFallback = false,
- bool subpixelAscentDescent = false) {
+ bool isTextOrientationFallback = false) {
return adoptRef(new SimpleFontData(platformData, std::move(customData),
- isTextOrientationFallback,
- subpixelAscentDescent));
+ isTextOrientationFallback));
}
const FontPlatformData& platformData() const { return m_platformData; }
@@ -161,14 +159,13 @@ class PLATFORM_EXPORT SimpleFontData : public FontData {
protected:
SimpleFontData(const FontPlatformData&,
PassRefPtr<CustomFontData> customData,
- bool isTextOrientationFallback = false,
- bool subpixelAscentDescent = false);
+ bool isTextOrientationFallback = false);
// Only used for testing.
SimpleFontData(const FontPlatformData&, PassRefPtr<OpenTypeVerticalData>);
private:
- void platformInit(bool subpixelAscentDescent);
+ void platformInit();
void platformGlyphInit();
PassRefPtr<SimpleFontData> createScaledFontData(const FontDescription&,
« no previous file with comments | « third_party/WebKit/Source/platform/fonts/FontMetrics.h ('k') | third_party/WebKit/Source/platform/fonts/SimpleFontData.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698