Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(747)

Unified Diff: third_party/WebKit/Source/platform/fonts/FontDataCache.cpp

Issue 2797423005: Always use original ascent/descent for FontMetrics::floatAscent|floatDescent (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/fonts/FontDataCache.cpp
diff --git a/third_party/WebKit/Source/platform/fonts/FontDataCache.cpp b/third_party/WebKit/Source/platform/fonts/FontDataCache.cpp
index 06f615c70b7a03034c84925e1c6af6f97b2ed4c4..66bc3eda746719d0cc0a2a2fd51ec9e9cb25b998 100644
--- a/third_party/WebKit/Source/platform/fonts/FontDataCache.cpp
+++ b/third_party/WebKit/Source/platform/fonts/FontDataCache.cpp
@@ -46,8 +46,7 @@ const unsigned cTargetInactiveFontData = 200;
PassRefPtr<SimpleFontData> FontDataCache::get(
const FontPlatformData* platformData,
- ShouldRetain shouldRetain,
- bool subpixelAscentDescent) {
+ ShouldRetain shouldRetain) {
if (!platformData)
return nullptr;
@@ -63,8 +62,7 @@ PassRefPtr<SimpleFontData> FontDataCache::get(
Cache::iterator result = m_cache.find(platformData);
if (result == m_cache.end()) {
std::pair<RefPtr<SimpleFontData>, unsigned> newValue(
- SimpleFontData::create(*platformData, nullptr, false,
- subpixelAscentDescent),
+ SimpleFontData::create(*platformData, nullptr),
shouldRetain == Retain ? 1 : 0);
// The new SimpleFontData takes a copy of the incoming FontPlatformData
// object. The incoming key may be temporary. So, for cache storage, take
« no previous file with comments | « third_party/WebKit/Source/platform/fonts/FontDataCache.h ('k') | third_party/WebKit/Source/platform/fonts/FontDescription.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698