Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Unified Diff: extensions/renderer/script_injection.h

Issue 2797423002: Do not log Extensions.InjectedScriptExecutionTime histograms if script not executed (Closed)
Patch Set: comments addressed Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | extensions/renderer/script_injection.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/script_injection.h
diff --git a/extensions/renderer/script_injection.h b/extensions/renderer/script_injection.h
index 8d57dd4c8812484d43d632bb01f9cc23ced0587e..3070e7a544c8b459a54e2f849d724fa789915194 100644
--- a/extensions/renderer/script_injection.h
+++ b/extensions/renderer/script_injection.h
@@ -13,6 +13,7 @@
#include "base/callback.h"
#include "base/macros.h"
#include "base/memory/weak_ptr.h"
+#include "base/optional.h"
#include "extensions/common/user_script.h"
#include "extensions/renderer/injection_host.h"
#include "extensions/renderer/script_injector.h"
@@ -84,9 +85,10 @@ class ScriptInjection {
const HostID& host_id() const { return injection_host_->id(); }
int64_t request_id() const { return request_id_; }
- // Called when JS injection for the given frame has been completed.
+ // Called when JS injection for the given frame has been completed or
+ // cancelled.
void OnJsInjectionCompleted(const std::vector<v8::Local<v8::Value>>& results,
- base::TimeDelta elapsed);
+ base::Optional<base::TimeDelta> elapsed);
private:
class FrameWatcher;
« no previous file with comments | « no previous file | extensions/renderer/script_injection.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698