Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 2797353003: MD Settings: Make up/down arrow work after closing the sidenav. (Closed)

Created:
3 years, 8 months ago by dpapad
Modified:
3 years, 8 months ago
Reviewers:
Dan Beam
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Make up/down arrow work after closing the sidenav. BUG=707106 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2797353003 Cr-Commit-Position: refs/heads/master@{#462304} Committed: https://chromium.googlesource.com/chromium/src/+/9b3c62205a0b13f99c59792b834f485b825e2cb8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M chrome/browser/resources/settings/settings_ui/settings_ui.html View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/settings_ui/settings_ui.js View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
dpapad
3 years, 8 months ago (2017-04-05 23:33:40 UTC) #6
Dan Beam
focus fixupppppp! lgtm
3 years, 8 months ago (2017-04-06 00:09:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2797353003/1
3 years, 8 months ago (2017-04-06 00:23:47 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 01:05:25 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9b3c62205a0b13f99c59792b834f...

Powered by Google App Engine
This is Rietveld 408576698