Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issue 2797343003: Support for parsing native function bodies with Fasta. (Closed)

Created:
3 years, 8 months ago by scheglov
Modified:
3 years, 8 months ago
Reviewers:
ahe, Paul Berry
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -15 lines) Patch
M pkg/analyzer/lib/src/dart/analysis/file_state.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/lib/src/fasta/ast_builder.dart View 3 chunks +26 lines, -3 lines 0 comments Download
M pkg/analyzer/test/generated/parser_fasta_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 2 chunks +11 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
3 years, 8 months ago (2017-04-06 18:59:03 UTC) #1
Paul Berry
lgtm
3 years, 8 months ago (2017-04-06 20:36:41 UTC) #2
scheglov
Committed patchset #1 (id:1) manually as 8c8a02ab4fe1922b078351a7e8be0f007483d639 (presubmit successful).
3 years, 8 months ago (2017-04-06 21:00:51 UTC) #4
ahe
3 years, 8 months ago (2017-04-07 10:48:04 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698