Issue 2797303005: [infra] Fixes for cross-toolchains

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2797303005: [infra] Fixes for cross-toolchains (Closed)

Created:
3 years, 8 months ago by zra

Modified:
3 years, 8 months ago

Reviewers:
rmacnak

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

[infra] Fixes for cross-toolchains toolchain_prefix was not correctly propagated everywhere it needed to go. This CL also adds an error to build.py if someone tries to use --toolchain as it is not supported there. R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/f1c7a22c43e0526fd06a25abb087a17f264c743e

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -14 lines)			Patch
M	DEPS	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	build/toolchain/linux/BUILD.gn	View	1	3 chunks	+22 lines, -12 lines	0 comments	Download
M	third_party/tcmalloc/BUILD.gn	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tools/build.py	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

zra

3 years, 8 months ago (2017-04-06 22:03:31 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
f1c7a22c43e0526fd06a25abb087a17f264c743e (presubmit successful).