Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2797303003: Fix for parsing annotations before variables in for-loop with Fasta. (Closed)

Created:
3 years, 8 months ago by scheglov
Modified:
3 years, 6 months ago
Reviewers:
ahe, Paul Berry
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix for parsing annotations before variables in for-loop with Fasta. R=paulberry@google.com, ahe@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/1b0b94c6e64848f5b9aebad73f5d258b0ec01f05

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -16 lines) Patch
M pkg/analyzer/lib/src/fasta/ast_builder.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/analyzer/test/generated/parser_fasta_test.dart View 1 chunk +0 lines, -12 lines 0 comments Download
M pkg/front_end/lib/src/fasta/parser/parser.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
3 years, 8 months ago (2017-04-05 20:16:15 UTC) #1
Paul Berry
lgtm
3 years, 8 months ago (2017-04-06 17:12:08 UTC) #2
scheglov
Committed patchset #1 (id:1) manually as 1b0b94c6e64848f5b9aebad73f5d258b0ec01f05 (presubmit successful).
3 years, 8 months ago (2017-04-06 18:00:01 UTC) #4
ahe
3 years, 6 months ago (2017-05-31 14:35:00 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698