Have ensureAttrNodeListForElement() return a reference

Have ensureAttrNodeListForElement() return a reference

Have ensureAttrNodeListForElement() return a reference instead of a pointer
as it can never return NULL. This makes the calling code look safer.

R=adamk
BUG=

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160034

[adamk, 2013-10-18 15:54:26]

lgtm with nit

https://codereview.chromium.org/27973004/diff/1/Source/core/dom/Element.cpp
File Source/core/dom/Element.cpp (right):

https://codereview.chromium.org/27973004/diff/1/Source/core/dom/Element.cpp#n...
Source/core/dom/Element.cpp:183: if (attrNodeList.at(i)->qualifiedName() ==
name)
Nit: you can take advantage of having a reference here by using [] instead of
at()

https://codereview.chromium.org/27973004/diff/1/Source/core/dom/Element.cpp#n...
Source/core/dom/Element.cpp:184: return attrNodeList.at(i).get();
Same here

[Inactive, 2013-10-18 16:06:51]

https://codereview.chromium.org/27973004/diff/1/Source/core/dom/Element.cpp
File Source/core/dom/Element.cpp (right):

https://codereview.chromium.org/27973004/diff/1/Source/core/dom/Element.cpp#n...
Source/core/dom/Element.cpp:183: if (attrNodeList.at(i)->qualifiedName() ==
name)
On 2013/10/18 15:54:26, adamk wrote:
> Nit: you can take advantage of having a reference here by using [] instead of
> at()

Done.

https://codereview.chromium.org/27973004/diff/1/Source/core/dom/Element.cpp#n...
Source/core/dom/Element.cpp:184: return attrNodeList.at(i).get();
On 2013/10/18 15:54:26, adamk wrote:
> Same here

Done.

[commit-bot: I haz the power, 2013-10-18 16:07:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/27973004/80001

[commit-bot: I haz the power, 2013-10-18 21:44:59]

Retried try job too often on win_blink_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_...

[commit-bot: I haz the power, 2013-10-18 21:50:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/27973004/80001

[commit-bot: I haz the power, 2013-10-19 03:10:52]

Retried try job too often on win_blink_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_...

[commit-bot: I haz the power, 2013-10-20 20:50:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/27973004/80001

[commit-bot: I haz the power, 2013-10-20 23:27:12]

Change committed as 160034