Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3148)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: base/files/file.cc

Issue 2797283002: Fixing std::swap(x, x) in base. (Closed)
Patch Set: Rebase. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/files/file_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/files/file.cc
diff --git a/base/files/file.cc b/base/files/file.cc
index 1b2224e323eecbb7ba87c323bfa867f4fcfad995..672950045a0d24e2ce08bdb56e4f25ec7315fecc 100644
--- a/base/files/file.cc
+++ b/base/files/file.cc
@@ -71,7 +71,6 @@ File File::CreateForAsyncHandle(PlatformFile platform_file) {
}
File& File::operator=(File&& other) {
- DCHECK_NE(this, &other);
Close();
SetPlatformFile(other.TakePlatformFile());
tracing_path_ = other.tracing_path_;
« no previous file with comments | « no previous file | base/files/file_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698