Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1178)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: base/values.cc

Issue 2797283002: Fixing std::swap(x, x) in base. (Closed)
Patch Set: Removing NOTREACHED from copy assignment. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« base/files/file_unittest.cc ('K') | « base/process/process_posix.cc ('k') | base/values_unittest.cc » ('j') | base/values_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/values.cc
diff --git a/base/values.cc b/base/values.cc
index 7ae3b630346cc30b797dd4c7e40b6a2a61afb5f8..37fcdb21f22135fb7e3cec24f840473d86784f83 100644
--- a/base/values.cc
+++ b/base/values.cc
@@ -185,7 +185,6 @@ Value& Value::operator=(const Value& that) {
}
Value& Value::operator=(Value&& that) {
- DCHECK(this != &that) << "attempt to self move assign.";
InternalCleanup();
InternalMoveConstructFrom(std::move(that));
« base/files/file_unittest.cc ('K') | « base/process/process_posix.cc ('k') | base/values_unittest.cc » ('j') | base/values_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698