Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1652)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: base/pickle.cc

Issue 2797283002: Fixing std::swap(x, x) in base. (Closed)
Patch Set: Removing NOTREACHED from copy assignment. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« base/files/file_unittest.cc ('K') | « base/files/file_unittest.cc ('k') | base/process/process_posix.cc » ('j') | base/values_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/pickle.cc
diff --git a/base/pickle.cc b/base/pickle.cc
index 02f39b57b7bb8133ad23501f2eb619117af2c0de..7c8420ba58338e7b9738043d6a207b4b6577353d 100644
--- a/base/pickle.cc
+++ b/base/pickle.cc
@@ -308,7 +308,6 @@ Pickle::~Pickle() {
Pickle& Pickle::operator=(const Pickle& other) {
if (this == &other) {
- NOTREACHED();
return *this;
}
if (capacity_after_header_ == kCapacityReadOnly) {
« base/files/file_unittest.cc ('K') | « base/files/file_unittest.cc ('k') | base/process/process_posix.cc » ('j') | base/values_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698