Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Unified Diff: PRESUBMIT.py

Issue 2797253011: Improve json_comment_eater.py performance. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: PRESUBMIT.py
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index ce91a4383343b14bdfbf264eb72a845c9ffd2988..004e59acbc355f64a1fb0f83a0caac5ef99a85a0 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -1413,6 +1413,9 @@ def _CheckParseErrors(input_api, output_api):
excluded_patterns = [
r'test[\\\/]data[\\\/]',
r'^components[\\\/]policy[\\\/]resources[\\\/]policy_templates\.json$',
+ # Contains valid JSON but is excluded for performance reasons. The
+ # well-formedness of this file is checked during the build.
+ r'^net[\\\/]http[\\\/]transport_security_state_static\.json$',
Dirk Pranke 2017/04/10 19:34:27 Seems like we should fix the comment eater instead
martijnc 2017/04/11 20:18:13 I've updated the CL to fix the performance issue i
]
# Most JSON files are preprocessed and support comments, but these do not.
json_no_comments_patterns = [
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698