Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2797253003: Declare dependency from dart_io targets to zlib (Closed)

Created:
3 years, 8 months ago by jamesr
Modified:
3 years, 8 months ago
Reviewers:
cutchccutchan, zra, jamesr1
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Declare dependency from dart_io targets to zlib runtime/bin/filter.cc uses zlib and is included in all of the dart_io variants, so those targets should declare a dependency on zlib. This dependency was being picked up incidentally by other targets before. R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/92e9a2b7c2d044bd6a26614c46c21e0f09fbd441

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M runtime/bin/BUILD.gn View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
jamesr1
3 years, 8 months ago (2017-04-05 20:35:55 UTC) #2
jamesr1
This popped up when cleaning up some other deps in Fuchsia, but I believe it ...
3 years, 8 months ago (2017-04-05 20:36:15 UTC) #3
zra
lgtm
3 years, 8 months ago (2017-04-05 20:43:22 UTC) #4
jamesr
3 years, 8 months ago (2017-04-05 23:41:35 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
92e9a2b7c2d044bd6a26614c46c21e0f09fbd441 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698